Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix workgroup identifiers for google ads access #6363

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

whd
Copy link
Member

@whd whd commented Oct 17, 2024

I didn't review https://github.com/mozilla/bigquery-etl/pull/6361/files very closely. The identifiers were correct on the datasets but not the tables, so I've disabled update-modules which applies table ACLs until this PR is merged to avoid spam in #dataops-alerts

┆Issue is synchronized with this Jira Task

@whd whd requested a review from kwindau October 17, 2024 02:10
@dataops-ci-bot
Copy link

Integration report for "chore: fix workgroup identifiers for google ads access"

sql.diff

Click to expand!
diff -bur --no-dereference --new-file /tmp/workspace/main-generated-sql/sql/moz-fx-data-shared-prod/mozilla_org/desktop_conversion_events/metadata.yaml /tmp/workspace/generated-sql/sql/moz-fx-data-shared-prod/mozilla_org/desktop_conversion_events/metadata.yaml
--- /tmp/workspace/main-generated-sql/sql/moz-fx-data-shared-prod/mozilla_org/desktop_conversion_events/metadata.yaml	2024-10-17 02:12:09.000000000 +0000
+++ /tmp/workspace/generated-sql/sql/moz-fx-data-shared-prod/mozilla_org/desktop_conversion_events/metadata.yaml	2024-10-17 02:12:26.000000000 +0000
@@ -2,8 +2,8 @@
 - role: roles/bigquery.dataViewer
   members:
   - workgroup:mozilla-confidential
-  - workgroup:external-ads-datafusion
-  - workgroup:external-ads-dataproc
+  - workgroup:google-managed/external-ads-datafusion
+  - workgroup:google-managed/external-ads-dataproc
 
 # Generated by bigquery_etl.dependency
 references:
diff -bur --no-dereference --new-file /tmp/workspace/main-generated-sql/sql/moz-fx-data-shared-prod/mozilla_org_derived/ga_desktop_conversions_v1/metadata.yaml /tmp/workspace/generated-sql/sql/moz-fx-data-shared-prod/mozilla_org_derived/ga_desktop_conversions_v1/metadata.yaml
--- /tmp/workspace/main-generated-sql/sql/moz-fx-data-shared-prod/mozilla_org_derived/ga_desktop_conversions_v1/metadata.yaml	2024-10-17 02:11:01.000000000 +0000
+++ /tmp/workspace/generated-sql/sql/moz-fx-data-shared-prod/mozilla_org_derived/ga_desktop_conversions_v1/metadata.yaml	2024-10-17 02:10:52.000000000 +0000
@@ -28,5 +28,5 @@
   members:
   - workgroup:dataops-managed/external-census
   - workgroup:mozilla-confidential
-  - workgroup:external-ads-datafusion
-  - workgroup:external-ads-dataproc
+  - workgroup:google-managed/external-ads-datafusion
+  - workgroup:google-managed/external-ads-dataproc
diff -bur --no-dereference --new-file /tmp/workspace/main-generated-sql/sql/moz-fx-data-shared-prod/mozilla_org_derived/ga_sessions_v2/metadata.yaml /tmp/workspace/generated-sql/sql/moz-fx-data-shared-prod/mozilla_org_derived/ga_sessions_v2/metadata.yaml
--- /tmp/workspace/main-generated-sql/sql/moz-fx-data-shared-prod/mozilla_org_derived/ga_sessions_v2/metadata.yaml	2024-10-17 02:11:01.000000000 +0000
+++ /tmp/workspace/generated-sql/sql/moz-fx-data-shared-prod/mozilla_org_derived/ga_sessions_v2/metadata.yaml	2024-10-17 02:10:52.000000000 +0000
@@ -29,5 +29,5 @@
   members:
   - workgroup:dataops-managed/external-census
   - workgroup:mozilla-confidential
-  - workgroup:external-ads-datafusion
-  - workgroup:external-ads-dataproc
+  - workgroup:google-managed/external-ads-datafusion
+  - workgroup:google-managed/external-ads-dataproc
diff -bur --no-dereference --new-file /tmp/workspace/main-generated-sql/sql/moz-fx-data-shared-prod/static/country_codes_v1/metadata.yaml /tmp/workspace/generated-sql/sql/moz-fx-data-shared-prod/static/country_codes_v1/metadata.yaml
--- /tmp/workspace/main-generated-sql/sql/moz-fx-data-shared-prod/static/country_codes_v1/metadata.yaml	2024-10-17 02:11:01.000000000 +0000
+++ /tmp/workspace/generated-sql/sql/moz-fx-data-shared-prod/static/country_codes_v1/metadata.yaml	2024-10-17 02:10:52.000000000 +0000
@@ -8,5 +8,5 @@
 - role: roles/bigquery.dataViewer
   members:
   - workgroup:dataops-managed/external-census
-  - workgroup:external-ads-datafusion
-  - workgroup:external-ads-dataproc
+  - workgroup:google-managed/external-ads-datafusion
+  - workgroup:google-managed/external-ads-dataproc

Link to full diff

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants