Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unblock Node upgrade by adding arbitrary c8 ignores #4234

Merged
merged 5 commits into from
Feb 21, 2024
Merged

Unblock Node upgrade by adding arbitrary c8 ignores #4234

merged 5 commits into from
Feb 21, 2024

Commits on Feb 19, 2024

  1. Add some tests/ignores for seeminly-uncovered code 

    It looks like c8 is now inconsistent in what it reports as
uncovered, but these additions are probably still a good idea.
    @Vinnl
    Vinnl committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    eec01f2 View commit details
    Browse the repository at this point in the history

Commits on Feb 21, 2024

  1. fix: c8 coverage

    @flozia
    flozia committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    5d7e17b View commit details
    Browse the repository at this point in the history

  2. chore: Add unit test for non-required ComboBox

    @flozia
    flozia committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    94fc9f1 View commit details
    Browse the repository at this point in the history

  3. chore: Remove jest --no-cache

    @flozia
    flozia committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    434a190 View commit details
    Browse the repository at this point in the history

  4. Add arbitrary c8 ignores 

    The Node 20.10 upgrade suddenly started marking them as uncovered.
It's unclear what exactly the cause is, but there's a bug on file
that might be related:
istanbuljs/v8-to-istanbul#236
    @Vinnl
    Vinnl committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    35f1b73 View commit details
    Browse the repository at this point in the history