Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNTOR-3776: cronjob to pull in the data brokers and refresh (part 2) #5291

Merged
merged 12 commits into from
Nov 13, 2024

Conversation

mansaj
Copy link
Collaborator

@mansaj mansaj commented Nov 7, 2024

References:

Jira: MNTOR-3776

Description

Part 2 of the ticket: cronjob to pull in the data brokers and refresh

How to test

npm run dev:cron:db-pull-data-brokers

Checklist (Definition of Done)

  • Commits in this PR are minimal and have descriptive commit messages.
  • I've added or updated the relevant sections in readme and/or code comments
  • If this PR implements a feature flag or experimentation, the Ship Behind Feature Flag status in Jira has been set
  • All acceptance criteria are met.

@mansaj mansaj changed the base branch from main to MNTOR-3776 November 7, 2024 19:16
Copy link

github-actions bot commented Nov 7, 2024

1 similar comment
Copy link

github-actions bot commented Nov 7, 2024

@mansaj mansaj marked this pull request as ready for review November 8, 2024 22:49
@mansaj mansaj requested a review from rhelmer November 8, 2024 22:49
package.json Show resolved Hide resolved
tracesSampleRate: 1.0,
});

const checkInId = Sentry.captureCheckIn({
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not harmful but we no longer have this service enabled in Sentry FYI

Copy link

Copy link
Collaborator

@rhelmer rhelmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found an issue while testing this, in

"/data-brokers?per_page=100&page=" + page.toString(),
where per_page is hardcoded.

getAllDataBrokers function is already using fetchAllPages so I think we just need pass the current/total pages correctly. I'll add that to this PR.

@rhelmer
Copy link
Collaborator

rhelmer commented Nov 13, 2024

I found an issue while testing this, in

"/data-brokers?per_page=100&page=" + page.toString(),

where per_page is hardcoded.

getAllDataBrokers function is already using fetchAllPages so I think we just need pass the current/total pages correctly. I'll add that to this PR.

Oh actually I take that back, it's just a bit confusing to read here but per_page is 100 and page is passed correctly, so this should be fine.

Base automatically changed from MNTOR-3776 to main November 13, 2024 00:29
@rhelmer rhelmer assigned rhelmer and mansaj and unassigned rhelmer Nov 13, 2024
Copy link

1 similar comment
Copy link

@rhelmer rhelmer merged commit e363235 into main Nov 13, 2024
16 checks passed
@rhelmer rhelmer deleted the MNTOR-3776-2 branch November 13, 2024 00:50
Copy link

Cleanup completed - database 'blurts-server-pr-5291' destroyed, cloud run service 'blurts-server-pr-5291' destroyed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants