-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MNTOR-3776: cronjob to pull in the data brokers and refresh (part 2) #5291
Conversation
Preview URL 🚀 : https://blurts-server-pr-5291-mgjlpikfea-uk.a.run.app |
1 similar comment
Preview URL 🚀 : https://blurts-server-pr-5291-mgjlpikfea-uk.a.run.app |
tracesSampleRate: 1.0, | ||
}); | ||
|
||
const checkInId = Sentry.captureCheckIn({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not harmful but we no longer have this service enabled in Sentry FYI
Preview URL 🚀 : https://blurts-server-pr-5291-mgjlpikfea-uk.a.run.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found an issue while testing this, in
"/data-brokers?per_page=100&page=" + page.toString(), |
per_page
is hardcoded.
getAllDataBrokers
function is already using fetchAllPages
so I think we just need pass the current/total pages correctly. I'll add that to this PR.
Oh actually I take that back, it's just a bit confusing to read here but |
Preview URL 🚀 : https://blurts-server-pr-5291-mgjlpikfea-uk.a.run.app |
1 similar comment
Preview URL 🚀 : https://blurts-server-pr-5291-mgjlpikfea-uk.a.run.app |
Cleanup completed - database 'blurts-server-pr-5291' destroyed, cloud run service 'blurts-server-pr-5291' destroyed |
References:
Jira: MNTOR-3776
Description
Part 2 of the ticket: cronjob to pull in the data brokers and refresh
How to test
npm run dev:cron:db-pull-data-brokers
Checklist (Definition of Done)