Fixed #113 - Fix 404s related to filer-dialogs #151
Conversation
|
@humphd This is tested, and increases the dist size by 25kb uncompressed. |
|
As a side note, it doesn't even look like filer-dialogs was being included at all before this. There are probably still some files missing that need to be added to the gruntfile's |
|
Sure, let's fully test this and get it working well. Also, can you unstage the changes to src/config.json |
|
@humphd This is ready to go now. |
| @@ -135,6 +135,8 @@ module.exports = function (grunt) { | |||
| '!thirdparty/CodeMirror2/mode/**/*.html', | |||
| '!thirdparty/CodeMirror2/**/*test.js', | |||
| 'thirdparty/CodeMirror2/theme/{,*/}*', | |||
| 'thirdparty/filer-dialogs/bower_components/font-awesome/css/font-awesome.min.css ', | |||
There was a problem hiding this comment.
One thing I'm wondering is whether this is a good idea at all. If we load it from here, and another extension wants to use it (HTMLHinter does atm), we'll end up loading it twice. Should we load it from https://cdnjs.cloudflare.com/ajax/libs/font-awesome/4.3.0/css/font-awesome.min.css or something?
There was a problem hiding this comment.
I think that's a better solution.
There was a problem hiding this comment.
It looks like HTMLHinter isn't using font-awesome. Is this still worth changing?
There was a problem hiding this comment.
I'd still like to find a way to not incur the cost of downloading these fonts + font-awesome, especially for cases where the dialogs are never shown. Could we somehow load that CSS only the first time we show those dialogs instead of always having to load it? It wouldn't be a huge deal to download those fonts after the app has started.
Does not work in case of a single browser because of adobe#10821.
Also, show the malformed message when such message comes in. Removed the TODO comment wrt sending back the error message: it is unclear what should be done if a malformed message comes in. It is unlikely it will ever happen and even then the error message in the browser should be enough.
It is a simple and robust fix for to address the page reloads, either inflicted by protocol commands or by user-driven page reloads.
Remove warning dialog for brackets in browser. Switch to Filer for all fs operations, update to latest API. NOTE: requires patched filer.js humphd/filer@25f2a24 Update filer to v0.0.13 to fix buffer regression Get initial project loading and File > Open working (style issues on dialog still) Change how styles are loaded First working File > Open Add sample file system generation Remove Filer submodule Add MakeDrive repo as submodule Switch things from Filer.* to MakeDrive.* Added save as functionality to UI Add makedrive sync logic in brackets Fix how trailing slashes are removed from dir names Added code to choose which extensions run in a browser environment Fix shared watches, update to auto-sync in MakeDrive vs. manual, use Path.normalize jquery module imports for sync-icon extension Update makedrive and makedrive-sync-icon submodules Allow withCredentials flag Update to use new MakeDrive client api for connect() without token Update MakeDrive for mozilla/makedrive@8d6f548 Update MakeDrive for CORS fixes Update MakeDrive with built version Update makedrive for CORS fix mozilla/makedrive#149 Update README Update MakeDrive to v0.0.12 for release Update MakeDrive to get Filer fix for sh.cwd/pwd() Update makedrive Update MakeDrive submodule update submodule for makedrive Update MakeDrive submodule 08-08-2014 - 10:57AM EST Update MakeDrive submodule
… versions with API's and new methods
… disabledExtensions
…r err objects.
…er.min in Brackets
…oke Blob URL: 'undefined'
Fix adobe#232 - [IE10] DOM7001: Invalid argument 'url'. Failed to revoke Blob URL: 'undefined'
No description provided.