Dockerize Bramble #557
Closed
Dockerize Bramble #557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've started reviewing this, I'll finish it in the next day or so. Looking good so far. |
|
Note: I haven't tested the Windows script. Will do that soon. |
| @@ -348,49 +340,6 @@ module.exports = function (grunt) { | |||
| tasks: ['jshint:test'] | |||
| } | |||
| }, | |||
| /* FIXME (jasonsanjose): how to handle extension tests */ | |||
There was a problem hiding this comment.
I wonder if we should delete test/* since we aren't running them ever?
There was a problem hiding this comment.
Yeah probably a good idea! I'll do that!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains two main parts:
I keep the whitespace changes in because they keep popping up. So future PRs will not have them anymore. If you want to ignore them during review, add
?w=1to the url.