fix for bug #454, adds _isHTML condition at HTMLServer.js:151 #567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix mozilla#530 - Figure out why DnD using the Upload Files dialog is broken
Rename pontoon string files to allow Pontoon to detect it
Rename cs/de properties files
Add script to pull string changes from thimble on build
Add comments to the locale strings
Change strings to not use placeholders for localizable words when possible
Fix thimble tarball extract pattern in string update script
Only use git in the script to update strings
mozilla#564) * Watch and warn on rename or delete events for the root index.html file, part of https://github.com/mozilla/thimble.mozilla.org/issues/1569#issuecomment-258889724 * Review fixes * Ignore .DSStore files when localizing, add new extension to sw precache list
…ame before creating a new file (mozilla#566) * Fix mozilla/thimble.mozilla.org#1564 - Check for existing file with name before creating a new file * Review Fix: Parentheses around ++ operator
|
Hi @NYCJacob, would you be able to make the PR against the mozilla:master branch instead of the mozilla:bramble branch? |
|
will do |
|
ok I synced my fork with your master and did another push. Is that good? |
|
@NYCJacob you would need to close this pull request and open a new one. In the new one, make sure the base fork's branch is master and not bramble. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds a conditional wrapper at line 151 - 170 before server(content)