Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #569: Merge Bramble with upstream Adobe Brackets (1.9 dev) #588

Merged
merged 16 commits into from
Feb 16, 2017
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .eslintrc.json
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
"no-multi-str": 2,
"no-fallthrough": 2,
"no-proto": 2,
"no-script-url": 2,
"no-script-url": 1,
"no-shadow": 0,
"no-shadow-restricted-names": 2,
"no-new-func": 2,
Expand Down
2 changes: 1 addition & 1 deletion Gruntfile.js
Original file line number Diff line number Diff line change
Expand Up @@ -660,7 +660,7 @@ module.exports = function (grunt) {
/*'cssmin',*/
/*'uglify',*/
'copy:dist',
'npm-install',
// 'npm-install',
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's git so you can always get this line back. If this isn't a work-in-progress PR, might as well just remove the line (and the commented lines above maybe?)

'cleanempty',
'usemin',
'build-config'
Expand Down
2 changes: 1 addition & 1 deletion templates/strings.template
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,6 @@

define({
{% for key, string in localizedStrings %}
"{{ key }}": "{{ string | dump }}"{{ "" if loop.last else "," }}
"{{ key }}": "{{ string | replace('\n', '\\n') }}"{{ "" if loop.last else "," }}
{%- endfor %}
});