Shifted turn server locally. #824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gideonthomas
suggested changes
Jul 6, 2017
package.json
Outdated
| @@ -16,6 +16,7 @@ | |||
| "anymatch": "1.3.0", | |||
| "aws-sdk": "^2.19.0", | |||
| "chokidar": "1.6.0", | |||
| "concurrently": "^3.5.0", | |||
package.json
Outdated
| @@ -46,8 +47,9 @@ | |||
| "pica": "^3.0.4", | |||
| "q": "1.4.1", | |||
| "semver": "^4.1.0", | |||
| "wolfy87-eventemitter": "^5.1.0", | |||
| "signal-master": "^1.0.1", | |||
package.json
Outdated
| @@ -73,7 +75,7 @@ | |||
| "preproduction": "grunt build-browser-compressed && npm run unlocalize", | |||
| "production": "npm start -- --gzip", | |||
| "test": "grunt test && grunt build-browser-compressed", | |||
| "server": "http-server -p 8000 --cors", | |||
| "server": "concurrently \"http-server -p 8000 --cors\" \"node node_modules/signal-master/server.js \"", | |||
There was a problem hiding this comment.
nit: break these down into:
"server:webrtc": "node node_modules/signal-master",
"server:static": "http-server -p 8000 --cors",
"server": "concurrently \"npm run server:webrtc\" \"npm run server:static\""| autoRequestMedia: false | ||
| autoRequestMedia: false, | ||
| // TODO : Shift this to config. | ||
| url: "localhost:8888" |
There was a problem hiding this comment.
Can you file an issue for this in Thimble? Ideally, we want this set via the bramble API on initialization and we can fallback on localhost.
gideonthomas
approved these changes
Jul 6, 2017
hkirat
added a commit
to hkirat/brackets
that referenced
this pull request
Aug 2, 2017
…ozilla#824) * Shifted turn server locally * Shifted concurrently and signal-master to devDependencies * Structured npm run start command
hkirat
added a commit
to hkirat/brackets
that referenced
this pull request
Aug 3, 2017
…ozilla#824) * Shifted turn server locally * Shifted concurrently and signal-master to devDependencies * Structured npm run start command
hkirat
added a commit
to hkirat/brackets
that referenced
this pull request
Aug 30, 2017
…ozilla#824) * Shifted turn server locally * Shifted concurrently and signal-master to devDependencies * Structured npm run start command
gideonthomas
pushed a commit
that referenced
this pull request
Aug 31, 2017
…824) * Shifted turn server locally * Shifted concurrently and signal-master to devDependencies * Structured npm run start command
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now we are using google's server
stun:stun1.l.google.com:19302for collaboration.In reference to #2350, we should shift to a local one.
This PR implements the same.