Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to clap 4 (getting rid of atty as a transitive dependency) #828

Closed
faern opened this issue Apr 18, 2023 · 2 comments · Fixed by #847
Closed

Upgrade to clap 4 (getting rid of atty as a transitive dependency) #828

faern opened this issue Apr 18, 2023 · 2 comments · Fixed by #847

Comments

@faern
Copy link

faern commented Apr 18, 2023

cbindgen is still depending on clap 3 which in turn depends no atty. An unmaintained crate with a known unsoundness issue. We are really trying to get rid of atty from our dependency tree, but we also need cbindgen. So this issue is about considering an upgrade to clap 4.
@faern faern changed the title Upgrade to clap 4 Upgrade to clap 4 (getting rid of atty as a transitive dependency) Apr 18, 2023
boxdot added a commit to boxdot/cbindgen that referenced this issue Jun 19, 2023
@boxdot
Upgrade clap 3 to clap 4
107fc5b 
This also removes the dependency on the unmaintained crate atty.

Closes mozilla#828
@boxdot boxdot mentioned this issue Jun 19, 2023
Merged
emilio pushed a commit that referenced this issue Aug 25, 2023
@boxdot @emilio
Upgrade clap 3 to clap 4
b734008 
This also removes the dependency on the unmaintained crate atty.

Closes #828
emilio pushed a commit that referenced this issue Aug 25, 2023
@boxdot @emilio
Upgrade clap 3 to clap 4
51ae4df 
This also removes the dependency on the unmaintained crate atty.

Closes #828
@faern
Copy link
Author

faern commented Aug 26, 2023

Please re-open since you merged a downgrade to clap 3 again in #868

@micahsnyder
Copy link

Yes please re-open this.

@faern faern mentioned this issue Sep 8, 2023
Closed
jschwe pushed a commit to jschwe/cbindgen that referenced this issue Dec 27, 2023
@boxdot @jschwe
Upgrade clap 3 to clap 4
a9ba8b8 
This also removes the dependency on the unmaintained crate atty.

Closes mozilla#828
jschwe pushed a commit to jschwe/cbindgen that referenced this issue Feb 24, 2024
@boxdot @jschwe
Upgrade clap 3 to clap 4
d73a789 
This also removes the dependency on the unmaintained crate atty.

Closes mozilla#828
emilio pushed a commit that referenced this issue Feb 26, 2024
@boxdot @emilio
Upgrade clap 3 to clap 4
d490485 
This also removes the dependency on the unmaintained crate atty.

Closes #828
@lgarron lgarron mentioned this issue Apr 5, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Upgrade clap 3 to clap 4 boxdot/cbindgen
2 participants
@faern @micahsnyder