Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unstable_ir feature flag that makes the ir pub #1011

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add unstable_ir feature flag that makes the ir pub #1011

wants to merge 1 commit into from
+16 −0

Conversation

heesooy
Copy link

@heesooy heesooy commented Oct 11, 2024 •
edited
Loading

Fixes #1009

@zhp46
Copy link

zhp46 commented Oct 11, 2024

This would be a fantastic addition to have

@heesooy heesooy marked this pull request as ready for review October 17, 2024 23:05
emilio
emilio requested changes Oct 27, 2024
View reviewed changes
Copy link
Collaborator

@emilio emilio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this is reasonable to do, but I don't want to make any change to the ir a breaking change.

Let's call this unstable_ir and document it with no stability guarantees in docs.md (that is, if you use this, you need to pin the library, and are on your own).

With that, this looks reasonable to me, if it simplifies life downstream compared to a fork...

@heesooy heesooy changed the title Add ir feature flag that makes the ir pub Add unstable_ir feature flag that makes the ir pub Oct 30, 2024
@heesooy heesooy requested a review from emilio October 30, 2024 21:54
@heesooy
Copy link
Author

heesooy commented Oct 30, 2024

I guess this is reasonable to do, but I don't want to make any change to the ir a breaking change.

Let's call this unstable_ir and document it with no stability guarantees in docs.md (that is, if you use this, you need to pin the library, and are on your own).

With that, this looks reasonable to me, if it simplifies life downstream compared to a fork...

@emilio -- done; renamed to unstable_ir and added a section in the docs. Let me know if you want me to move the docs to a different section, wasn't sure where would be best. Thanks for taking a look!

@heesooy
Add unstable_ir feature flag that makes the ir pub
efd16e6 
Rename to unstable_ir, add docs

Push omitted file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilio emilio Awaiting requested review from emilio

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make ir module public
3 participants
@heesooy @zhp46 @emilio