-
Notifications
You must be signed in to change notification settings - Fork 307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update syn related dependencies to 1.0 #379
Conversation
@dtolnay is serde-rs/serde#1591 expected to land soon-ish? If so we may as well wait for that. |
Done |
4d9a486
to
2875929
Compare
Travis is always complaining 😄 |
There, should be fixed |
syn::Item::TraitAlias(ref item) => (|$i: &syn::ItemTraitAlias| $a)(item), | ||
syn::Item::Verbatim(_) => (|| $b)(), | ||
_ => panic!("Unhandled syn::Item: {:?}", $s), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd prefer to keep handling the others.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately https://docs.rs/syn/1.0.3/src/syn/item.rs.html#79
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
r=me with a rustfmt pass (travis is mad because of it) and this warning fixed:
warning: unused import: `std::mem`
--> src/bindgen/ir/constant.rs:8:5
Thanks!
Oh, also, mind not doing the Cargo.toml version bump? I hope to merge #377 soonish, though I may as well do two releases so no big deal I guess. |
Sure, I'll remove it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Changelog: ## 0.9.1 * Various improvements to comment output. mozilla/cbindgen#370 / mozilla/cbindgen#375. * Fixed expand when ran from build.rs. mozilla/cbindgen#371 * More debugging output for expansion. mozilla/cbindgen#383 * New option to add a default private constructor in C++ tagged enums. mozilla/cbindgen#377 * Syn and related dependencies updated to 1.0. mozilla/cbindgen#379
No description provided.