Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reawaken development #204

Merged
merged 12 commits into from
Jan 24, 2024
Merged

Reawaken development #204

merged 12 commits into from
Jan 24, 2024

Conversation

stevejalim
Copy link
Contributor

@stevejalim stevejalim commented Jan 24, 2024

This changeset aims to jump start development on the project.

  • Update tox matrix to test against latest/non-EOL Django and Python versions
  • Update CI to use GHA instead of CircleCI
  • Drop six (resolves Remove package six  #199)
  • Swap pep8 and flake8 for ruff
  • Add support for pre-commit

Once this is merged to main, we can look at any outstanding PRs and merge those that are safe/OK to merge. We'll then look to do a 3.8alpha or 3.8rc release, before a formal 3.8 release.

The longer goal remains to get the project into a state where it can hopefully be absorbed into Django Core - see #135

@stevejalim stevejalim self-assigned this Jan 24, 2024
@stevejalim stevejalim force-pushed the support-latest-djangos-and-pythons branch 2 times, most recently from 874e50b to 6c6ab4d Compare January 24, 2024 15:18
@stevejalim stevejalim force-pushed the support-latest-djangos-and-pythons branch from 6c6ab4d to 3eadb4c Compare January 24, 2024 15:24
@stevejalim stevejalim force-pushed the support-latest-djangos-and-pythons branch from 3eadb4c to 111c78f Compare January 24, 2024 16:28
@stevejalim stevejalim force-pushed the support-latest-djangos-and-pythons branch from 235af88 to ef195a1 Compare January 24, 2024 16:42
@stevejalim
Copy link
Contributor Author

@tim-schilling I'd welcome your review on this, too, if you don't mind

@stevejalim stevejalim changed the title Support latest djangos and pythons Reawaken development Jan 24, 2024
This was referenced Jan 24, 2024
@stevejalim stevejalim force-pushed the support-latest-djangos-and-pythons branch from 9c1e81d to b00c829 Compare January 24, 2024 17:11
tox.ini Outdated Show resolved Hide resolved
Copy link
Contributor

@tim-schilling tim-schilling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me. I didn't run anything, just gave the code a once over. The issue I spotted wouldn't harm anything even.

Co-authored-by: Tim Schilling <tim@aspiredu.com>
csp/tests/test_utils.py Outdated Show resolved Hide resolved
setup.cfg Show resolved Hide resolved
Copy link
Member

@robhudson robhudson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+wc - just noticed some string clean-up that isn't necessary but a nice-to-have to avoid awkward concatenations, presumably from the automated formatting.

@stevejalim stevejalim force-pushed the support-latest-djangos-and-pythons branch from 2a99dc9 to a5bf0b3 Compare January 24, 2024 21:18
@stevejalim stevejalim merged commit b49b4f8 into main Jan 24, 2024
9 checks passed
@stevejalim stevejalim deleted the support-latest-djangos-and-pythons branch January 24, 2024 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants