Restore completed_overview logic fixes #541

mozilla · Sep 20, 2018 · 4e8d19f · 4e8d19f
1 parent cd3a6b1
commit 4e8d19f
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 0 deletions.
diff --git a/app/experimenter/experiments/models.py b/app/experimenter/experiments/models.py
@@ -272,6 +272,10 @@ def is_begun(self):
     def is_high_risk(self):
         return True in self._risk_questions
 
+    @property
+    def completed_overview(self):
+        return self.pk is not None
+
     @property
     def completed_population(self):
         return (

diff --git a/app/experimenter/experiments/tests/test_models.py b/app/experimenter/experiments/tests/test_models.py
@@ -414,6 +414,14 @@ def test_experiment_is_begun(self):
             experiment = ExperimentFactory.create_with_status(status)
             self.assertTrue(experiment.is_begun)
 
+    def test_overview_is_not_complete_when_not_saved(self):
+        experiment = ExperimentFactory.build()
+        self.assertFalse(experiment.completed_overview)
+
+    def test_overview_is_complete_when_saved(self):
+        experiment = ExperimentFactory.create()
+        self.assertTrue(experiment.completed_overview)
+
     def test_population_is_not_complete_when_defaults_set(self):
         experiment = ExperimentFactory.create(
             population_percent=0.0, firefox_version="", firefox_channel=""