Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation on testing BigQuery from ingestion-beam #543

Merged
merged 4 commits into from
Apr 29, 2019

Conversation

acmiyaguchi
Copy link
Contributor

This adds some documentation on a workflow for testing against data in PubSub from the various sinks in ingestion-beam.

Copy link
Contributor

@jklukas jklukas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice. Thanks for adding this!

@@ -0,0 +1,27 @@
graph TD

subgraph dataops/sandbox/my-project
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to decrease the font sizes? This is rendering strangely for me where most of the text looks clipped inside the boxes:

Screen Shot 2019-04-29 at 8 58 51 AM

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like this will fix it -- mermaid-js/mermaid#790 (comment)

The online editor does the right thing. I think the mermaid cli tool and the online tool are out of sync.

image

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks better for me now too.

@codecov-io
Copy link

codecov-io commented Apr 29, 2019

Codecov Report

Merging #543 into master will decrease coverage by 6.23%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #543      +/-   ##
============================================
- Coverage     89.28%   83.05%   -6.24%     
+ Complexity      338      325      -13     
============================================
  Files            56       56              
  Lines          1894     1894              
  Branches        177      177              
============================================
- Hits           1691     1573     -118     
- Misses          139      265     +126     
+ Partials         64       56       -8
Flag Coverage Δ Complexity Δ
#ingestion_beam 80.36% <ø> (-7.22%) 325 <ø> (-13)
#ingestion_edge 100% <ø> (ø) 0 <ø> (ø) ⬇️
Impacted Files Coverage Δ Complexity Δ
...m/src/main/java/com/mozilla/telemetry/io/Read.java 50% <0%> (-50%) 1% <0%> (ø)
.../telemetry/transforms/PubsubMessageToTableRow.java 38.23% <0%> (-33.83%) 23% <0%> (-10%)
.../src/main/java/com/mozilla/telemetry/io/Write.java 66.02% <0%> (-28.21%) 1% <0%> (ø)
...ozilla/telemetry/transforms/PubsubConstraints.java 53.65% <0%> (-26.83%) 7% <0%> (ø)
...java/com/mozilla/telemetry/options/OutputType.java 78.94% <0%> (-21.06%) 1% <0%> (ø)
.../java/com/mozilla/telemetry/options/InputType.java 80% <0%> (-20%) 1% <0%> (ø)
...la/telemetry/transforms/MapElementsWithErrors.java 85.71% <0%> (-10.72%) 4% <0%> (ø)
...ava/com/mozilla/telemetry/options/SinkOptions.java 72% <0%> (-8%) 5% <0%> (-2%)
...mozilla/telemetry/transforms/LimitPayloadSize.java 92.85% <0%> (-7.15%) 4% <0%> (-1%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5bb0aba...77a776d. Read the comment docs.

@acmiyaguchi acmiyaguchi merged commit b2a64c3 into mozilla:master Apr 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants