Skip to content

Commit

Permalink
Bug 1565150 [wpt PR 17754] - Fix regression in webdriver tests, a=tes…
Browse files Browse the repository at this point in the history
…tonly

Automatic update from web-platform-tests
Fix regression in webdriver tests

A large number of tests in webdriver directory are currently failing,
due to a change in the parameters of Find.css method by PR #17260,
which broke any tests that still supply the old parameters.

This commit changes the parameter order and uses default parameter value
to make the parameter list compatible with the old one.

--

wpt-commits: d528abff035d6596f68f21a9510ee1c5b58a1e48
wpt-pr: 17754
  • Loading branch information
JohnChen0 authored and jgraham committed Jul 24, 2019
1 parent 66af760 commit 1f18ef6
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -313,7 +313,7 @@ def __init__(self, session):
self.session = session

@command
def css(self, element_selector, frame, all=True):
def css(self, element_selector, all=True, frame="window"):
if (frame != "window"):
self.session.switch_frame(frame)
elements = self._find_element("css selector", element_selector, all)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,7 @@ def elements_by_selector(self, selector):
return self.webdriver.find.css(selector)

def elements_by_selector_and_frame(self, element_selector, frame):
return self.webdriver.find.css(element_selector, frame)
return self.webdriver.find.css(element_selector, frame=frame)


class WebDriverClickProtocolPart(ClickProtocolPart):
Expand Down

0 comments on commit 1f18ef6

Please sign in to comment.