Skip to content

Commit

Permalink
Bug 1677562 - Remove eslint-plugin-prettier now that Prettier and ESL…
Browse files Browse the repository at this point in the history
…int are separated. r=Gijs,devtools-reviewers,ochameau

Depends on D175769

Differential Revision: https://phabricator.services.mozilla.com/D175770
  • Loading branch information
Standard8 committed Apr 19, 2023
1 parent f811358 commit 35384ac
Show file tree
Hide file tree
Showing 9 changed files with 1,161 additions and 1,191 deletions.
2 changes: 0 additions & 2 deletions browser/components/newtab/.eslintrc.js
Original file line number Diff line number Diff line change
Expand Up @@ -112,8 +112,6 @@ module.exports = {
},
],
rules: {
"prettier/prettier": "off",

"fetch-options/no-fetch-credentials": "error",

"react/jsx-boolean-value": ["error", "always"],
Expand Down
4 changes: 1 addition & 3 deletions devtools/client/debugger/src/.eslintrc.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
* file, You can obtain one at <http://mozilla.org/MPL/2.0/>. */

module.exports = {
plugins: ["react", "mozilla", "@babel", "prettier", "import", "file-header"],
plugins: ["react", "mozilla", "@babel", "import", "file-header"],
globals: {
atob: true,
btoa: true,
Expand Down Expand Up @@ -47,8 +47,6 @@ module.exports = {
jest: true,
},
rules: {
"prettier/prettier": "off",

// These are the rules that have been configured so far to match the
// devtools coding style.

Expand Down
1,198 changes: 636 additions & 562 deletions package-lock.json

Large diffs are not rendered by default.

15 changes: 7 additions & 8 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,28 +4,27 @@
"repository": {},
"license": "MPL-2.0",
"devDependencies": {
"@babel/core": "7.20.12",
"@babel/eslint-parser": "7.19.1",
"@babel/core": "7.21.4",
"@babel/eslint-parser": "7.21.3",
"@babel/eslint-plugin": "7.19.1",
"@babel/plugin-syntax-jsx": "7.18.6",
"@babel/plugin-syntax-jsx": "7.21.4",
"@microsoft/eslint-plugin-sdl": "github:mozfreddyb/eslint-plugin-sdl#17b22cd527682108af7a1a4edacf69cb7a9b4a06",
"eslint": "8.33.0",
"eslint-config-prettier": "8.6.0",
"eslint": "8.38.0",
"eslint-config-prettier": "8.8.0",
"eslint-plugin-eslint-plugin": "5.0.8",
"eslint-plugin-fetch-options": "0.0.5",
"eslint-plugin-file-header": "0.0.1",
"eslint-plugin-html": "7.1.0",
"eslint-plugin-import": "2.27.5",
"eslint-plugin-jest": "23.20.0",
"eslint-plugin-jsdoc": "39.7.4",
"eslint-plugin-jsdoc": "39.9.1",
"eslint-plugin-jsx-a11y": "6.7.1",
"eslint-plugin-mozilla": "file:tools/lint/eslint/eslint-plugin-mozilla",
"eslint-plugin-no-unsanitized": "4.0.2",
"eslint-plugin-prettier": "3.4.0",
"eslint-plugin-react": "7.29.4",
"eslint-plugin-react-hooks": "4.6.0",
"eslint-plugin-spidermonkey-js": "file:tools/lint/eslint/eslint-plugin-spidermonkey-js",
"jsdoc": "4.0.0",
"jsdoc": "4.0.2",
"prettier": "1.19.1",
"yarn": "1.22.19"
},
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ module.exports = {
},

// When adding items to this file please check for effects on sub-directories.
plugins: ["html", "fetch-options", "prettier", "no-unsanitized"],
plugins: ["html", "fetch-options", "no-unsanitized"],

// When adding items to this file please check for effects on all of toolkit
// and browser
Expand Down Expand Up @@ -339,8 +339,6 @@ module.exports = {
// This may conflict with prettier, so turn it off.
"prefer-arrow-callback": "off",

"prettier/prettier": "off",

// This generates too many false positives that are not easy to work around,
// and false positives seem to be inherent in the rule.
"require-atomic-updates": "off",
Expand Down
4 changes: 2 additions & 2 deletions tools/lint/eslint/eslint-plugin-mozilla/manifest.tt
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
[
{
"filename": "eslint-plugin-mozilla.tar.gz",
"size": 11475311,
"size": 9278498,
"algorithm": "sha512",
"digest": "309cab6d8a66533505decc708d1f0a6f65c1a639c4c2c740b0c0649d766efe8206c0b51abaa59ae990c201dc039ac8b0295987f2862ac5b568b4e8e9341300ca",
"digest": "01615c6a29c0027fabe528d9a6e2133b80467e0e0c420bab3a282dea3c8de1fd59c44dab0fcdb19c09e72c7d0d7e81347029336e77b4463a8c09272876da10a8",
"unpack": true,
"visibility": "public"
}
Expand Down
Loading

0 comments on commit 35384ac

Please sign in to comment.