Bug 1032731 - hack sdk/deprecated/unit-test-finder to work with new loader #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| const { isNative } = require('@loader/options'); | ||
|
|
||
| const cuddlefish = isNative ? require("toolkit/loader") : require("../loader/cuddlefish"); |
There was a problem hiding this comment.
I know cfx has a problem with extra requires, and it'll reload toolkit/loader, but just double checking that this still works in cfx
|
(Mass-PR-close) |
|
This was just for diff/review purposes |
|
To avoid confusion with new contributors (who may see open PRs and think it's the accepted way to submit patches), would you mind using a branch on a personal repo instead? :-) |
|
Will do! |
ekr
pushed a commit
to ekr/gecko-dev
that referenced
this pull request
Sep 18, 2014
Make it build (but sacrifice unit tests)
walac
pushed a commit
to walac/gecko-dev
that referenced
this pull request
Nov 24, 2014
…2g_desktop Bug 1102010 - run build unit tests against b2g desktop
rainemak
pushed a commit
to rainemak/gecko-dev-mirror
that referenced
this pull request
Jul 20, 2015
…sk_jb30162 [xulrunner] Add an API for posting external tasks to compositor thread. Contributes to JB#30162.
ChunMinChang
pushed a commit
to ChunMinChang/gecko-dev
that referenced
this pull request
Jul 7, 2016
Bug 1283389 - Allow only five remote controllers to pair with TV
moz-v2v-gh
pushed a commit
that referenced
this pull request
Sep 3, 2017
…or_cookie Implement Into<cookie::Cookie> for Cookie Source-Repo: https://github.com/mozilla/webdriver-rust Source-Revision: 2ee8645d6f5088c6d4b6bc8ad46466e290105418 --HG-- extra : subtree_source : http%3A//tristan.corp.lon2.mozilla.com%3A8000 extra : subtree_revision : febdc4ffa784e71e23b58acac879b148ba4e98fb
aethanyc
pushed a commit
to aethanyc/gecko-dev
that referenced
this pull request
Sep 4, 2017
…alize_for_cookie Implement Into<cookie::Cookie> for Cookie Source-Repo: https://github.com/mozilla/webdriver-rust Source-Revision: 2ee8645d6f5088c6d4b6bc8ad46466e290105418
daoshengmu
pushed a commit
to daoshengmu/gecko-dev
that referenced
this pull request
Sep 8, 2017
…alize_for_cookie Implement Into<cookie::Cookie> for Cookie Source-Repo: https://github.com/mozilla/webdriver-rust Source-Revision: 2ee8645d6f5088c6d4b6bc8ad46466e290105418
moz-v2v-gh
pushed a commit
that referenced
this pull request
Dec 28, 2019
Pick commits: acb90e9 - Add license for mixer crate 82e7ff9 - Move criterion crate to [dev-dependencies] f8b7d96 - Implement a new any-to-any mixer (#23) ae43813 - Remove the test_set_channel_layout_input (#32) 9d0a0e8 - Improve device switch tests (#14) 833a062 - Enable test_ops_stream_register_device_changed_callback (#33) Differential Revision: https://phabricator.services.mozilla.com/D58177 --HG-- extra : moz-landing-system : lando
luyahan
added a commit
to luyahan/gecko-dev
that referenced
this pull request
Sep 16, 2022
cfallin
pushed a commit
to cfallin/gecko-dev
that referenced
this pull request
Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.