Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import of v0.35.0 #2188

Merged
merged 1 commit into from
Aug 6, 2024
Merged

Import of v0.35.0 #2188

merged 1 commit into from
Aug 6, 2024

Conversation

whimboo
Copy link
Collaborator

@whimboo whimboo commented Aug 1, 2024

No description provided.

@whimboo whimboo marked this pull request as draft August 1, 2024 12:47
@whimboo whimboo force-pushed the do_release_0.35.0 branch 2 times, most recently from 82a546a to db409cb Compare August 5, 2024 22:09
@whimboo whimboo marked this pull request as ready for review August 5, 2024 22:10
@whimboo
Copy link
Collaborator Author

whimboo commented Aug 6, 2024

Does one of you have issues as well building geckodriver because of the following error?

    error[E0282]: type annotations needed for `Box<_>`
      --> /Users/henrik/.cargo/registry/src/index.crates.io-6f17d22bba15001f/time-0.3.31/src/format_description/parse/mod.rs:83:9
       |
    83 |     let items = format_items
       |         ^^^^^
    ...
    86 |     Ok(items.into())
       |              ---- type must be known at this point
       |
    help: consider giving `items` an explicit type, where the placeholders `_` are specified
       |
    83 |     let items: Box<_> = format_items
       |              ++++++++

@whimboo
Copy link
Collaborator Author

whimboo commented Aug 6, 2024

Actually running a cargo update fixed the problem for me. I assume that we updated all these crates already on mozilla-central so that we do not see the failure over there.

@whimboo whimboo merged commit 53f2b32 into mozilla:release Aug 6, 2024
@whimboo whimboo deleted the do_release_0.35.0 branch August 6, 2024 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants