This repository has been archived by the owner on Sep 13, 2023. It is now read-only.
Fix lmdb pkgconf name: liblmdb -> lmdb #95
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
build.rs currently never finds the system-provided lmdb library. pkgconf (or pkg-config) expects the name of the .pc file, not the name of the library file, and lmdb provides lmdb.pc (checked in Alpine Linux, Debian, Fedora). This has been already proposed in the original project: danburkert#53
bors bot
added a commit
to meilisearch/lmdb-rs
that referenced
this pull request
Sep 15, 2022
10: Fix lmdb pkgconf name: liblmdb -> lmdb r=Kerollmops a=jirutka Fixes #9 build.rs currently never finds the system-provided lmdb library. pkgconf (or pkg-config) expects the name of the .pc file, not the name of the library file, and lmdb provides `lmdb.pc`, not `liblmdb.pc` (checked in Alpine Linux, Debian, Fedora). This has been already proposed in the original project: danburkert#53. I’ve opened this pull request also in Mozilla’s fork: mozilla#95. Shouldn’t lmdb-sys also declare `links` in Cargo.toml? Co-authored-by: Jakub Jirutka <jakub@jirutka.cz>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
build.rs currently never finds a system-provided lmdb library. pkgconf (or pkg-config) expects name of the .pc file, not name of the library file, and lmdb provides lmdb.pc (checked in Alpine Linux, Debian, Fedora).
This has been already proposed in the original project: danburkert#53
Shouldn’t lmdb-sys also declare
linksin Cargo.toml?