Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update macos-background-tab-power-savings.toml #358

Merged
merged 2 commits into from
Feb 12, 2024
Merged

Update macos-background-tab-power-savings.toml #358

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
92d7bd4
Update macos-background-tab-power-savings.toml
danielkberry Feb 12, 2024
c44a70e
Update macos-background-tab-power-savings.toml
danielkberry Feb 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
73 changes: 53 additions & 20 deletions jetstream/macos-background-tab-power-savings.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,29 +1,29 @@
[metrics]

overall = [
"fx_tab_switch_update_ms",
"fx_tab_switch_total_e10s_ms",
"fx_tab_switch_composite_e10s_ms",
"fx_tab_switch_update_ms",
"fx_tab_switch_total_e10s_ms",
"fx_tab_switch_composite_e10s_ms",
"fx_tab_switch_spinner_visible_ms",
"fx_tab_switch_spinner_visible_long_ms",
"fx_tab_switch_spinner_visible_long_ms",
"fx_tab_switch_spinner_visible_trigger",
"fx_tab_switch_request_tab_warming_state",
"fx_tab_switch_request_tab_warming_state",
"fx_tab_click_ms",
]

weekly = [
"fx_tab_switch_update_ms",
"fx_tab_switch_total_e10s_ms",
"fx_tab_switch_composite_e10s_ms",
"fx_tab_switch_update_ms",
"fx_tab_switch_total_e10s_ms",
"fx_tab_switch_composite_e10s_ms",
"fx_tab_switch_spinner_visible_ms",
"fx_tab_switch_spinner_visible_long_ms",
"fx_tab_switch_spinner_visible_long_ms",
"fx_tab_switch_spinner_visible_trigger",
"fx_tab_switch_request_tab_warming_state",
"fx_tab_switch_request_tab_warming_state",
"fx_tab_click_ms",
]

[metrics.fx_tab_switch_update_ms]
data_source = "main"
data_source = "main_filtered"
select_expression = "{{agg_histogram_mean('payload.histograms.fx_tab_switch_update_ms')}}"

friendly_name = "Fx Tab Switch Update Ms"
Expand All @@ -34,11 +34,8 @@ type = "histogram"
[metrics.fx_tab_switch_update_ms.statistics.bootstrap_mean]





[metrics.fx_tab_switch_spinner_visible_ms]
data_source = "main"
data_source = "main_filtered"
select_expression = "{{agg_histogram_mean('payload.histograms.fx_tab_switch_spinner_visible_ms')}}"

friendly_name = "Fx Tab Switch Spinner Visible Ms"
Expand All @@ -49,7 +46,7 @@ type = "histogram"
[metrics.fx_tab_switch_spinner_visible_ms.statistics.bootstrap_mean]

[metrics.fx_tab_switch_spinner_visible_long_ms]
data_source = "main"
data_source = "main_filtered"
select_expression = "{{agg_histogram_mean('payload.histograms.fx_tab_switch_spinner_visible_long_ms')}}"

friendly_name = "Fx Tab Switch Spinner Visible Long Ms"
Expand All @@ -60,7 +57,7 @@ type = "histogram"
[metrics.fx_tab_switch_spinner_visible_long_ms.statistics.bootstrap_mean]

[metrics.fx_tab_switch_spinner_visible_trigger]
data_source = "main"
data_source = "main_filtered"
select_expression = "{{agg_histogram_mean('payload.histograms.fx_tab_switch_spinner_visible_trigger')}}"

friendly_name = "Fx Tab Switch Spinner Visible Trigger"
Expand All @@ -71,7 +68,7 @@ type = "histogram"
[metrics.fx_tab_switch_spinner_visible_trigger.statistics.bootstrap_mean]

[metrics.fx_tab_switch_request_tab_warming_state]
data_source = "main"
data_source = "main_filtered"
select_expression = "{{agg_histogram_mean('payload.histograms.fx_tab_switch_request_tab_warming_state')}}"

friendly_name = "Fx Tab Switch Request Tab Warming State"
Expand All @@ -82,7 +79,7 @@ type = "histogram"
[metrics.fx_tab_switch_request_tab_warming_state.statistics.bootstrap_mean]

[metrics.fx_tab_click_ms]
data_source = "main"
data_source = "main_filtered"

select_expression = "{{agg_histogram_mean('payload.histograms.fx_tab_click_ms')}}"

Expand All @@ -93,5 +90,41 @@ type = "histogram"

[metrics.fx_tab_click_ms.statistics.bootstrap_mean]

[metrics.fx_tab_switch_total_e10s_ms.statistics.bootstrap_mean]
[metrics.fx_tab_switch_composite_e10s_ms]
data_source = "main_filtered"

select_expression = "{{agg_histogram_mean('payload.histograms.fx_tab_switch_composite_e10s_ms')}}"

friendly_name = "Fx Tab Click Ms"
description = "Firefox: Time in ms spent on switching tabs in response to a tab click."
category = "performance"
type = "histogram"

[metrics.fx_tab_switch_composite_e10s_ms.statistics.bootstrap_mean]

[metrics.fx_tab_switch_total_e10s_ms]
data_source = "main_filtered"

select_expression = "{{agg_histogram_mean('payload.histograms.fx_tab_switch_total_e10s_ms')}}"

friendly_name = "Fx Tab Click Ms"
description = "Firefox: Time in ms spent on switching tabs in response to a tab click."
category = "performance"
type = "histogram"

[metrics.fx_tab_switch_total_e10s_ms.statistics.bootstrap_mean]


[data_sources]
[data_sources.main_filtered]
from_expression = """(
SELECT
*,
DATE(submission_timestamp) AS submission_date,
environment.experiments
FROM `moz-fx-data-shared-prod.telemetry_stable.main_v5`
WHERE mozfun.map.get_key(environment.experiments, 'macos-background-tab-power-savings') IS NOT NULL
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

filtering on the beta channel might speed up things even more here (afaik this experiment is running on beta)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we do that automatically when building these queries? I believe channel should be in the Experimenter API

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's a little more complicated. I opened mozilla/jetstream#1827 a while ago which mentions this as well

)"""
experiments_column_type = "native"
friendly_name = "Main"
description = "Main ping table"
Loading