Skip to content

Commit

Permalink
ci: Fix Firefox build on Windows (#2109)
Browse files Browse the repository at this point in the history
* ci: Fix Firefox build on Windows

* Exit

* Check

* WindowsSdkDir

* Finalize

* Also only PR-comment if we tried to build
  • Loading branch information
larseggert authored Sep 16, 2024
1 parent ee8a696 commit 5410bd0
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions .github/workflows/firefox.yml
Original file line number Diff line number Diff line change
Expand Up @@ -116,8 +116,10 @@ jobs:
EXT: ${{ runner.os == 'macOS' && '.app' || '' }}
run: |
cd mozilla-unified
# Work around "ERROR: WINDOWSSDKDIR cannot be set when using the bootstrapped WINSYSROOT"
# (Capitalization "WindowsSdkDir" matters)
[ "${{ runner.os }}" == "Windows" ] && unset WindowsSdkDir
./mach build && tar -cf "../$FIREFOX.tar" -C "../$FIREFOX/dist" "$NAME$TYPE$EXT"
exit 0
- name: Export binary
id: upload
Expand All @@ -138,7 +140,7 @@ jobs:

comment:
name: Comment on PR
if: always()
if: github.event.pull_request.draft == false
needs: firefox
runs-on: ubuntu-latest
steps:
Expand Down

0 comments on commit 5410bd0

Please sign in to comment.