Skip to content

Commit

Permalink
fix(bin/bench): rename 1-conn/10_000-1b-seq-resp to parallel (#1796)
Browse files Browse the repository at this point in the history
The benchmark is using the default concurrency factor. By default `neqo-client`
runs up to `100` requests in parallel.

https://github.com/mozilla/neqo/blob/5dfe106669ccb695187511305c21b8e8a8775e91/neqo-bin/src/client/mod.rs#L151-L153

Thus the benchmark name is wrong, i.e. the requests are run in parallel and not
sequentially.
  • Loading branch information
mxinden authored Apr 8, 2024
1 parent e38e3cf commit aca1352
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion neqo-bin/benches/main.rs
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ fn transfer(c: &mut Criterion) {
sample_size: Some(10),
},
Benchmark {
name: "1-conn/10_000-1b-seq-resp (aka. RPS)".to_string(),
name: "1-conn/10_000-parallel-1b-resp (aka. RPS)".to_string(),
requests: vec![1; 10_000],
sample_size: None,
},
Expand Down

0 comments on commit aca1352

Please sign in to comment.