Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(github): qns comment on failure only and update existing #1720

Merged
merged 1 commit into from
Mar 7, 2024

Conversation

mxinden
Copy link
Collaborator

@mxinden mxinden commented Mar 7, 2024

Once the QUIC Network Simulator workflow finished, the QUIC Network Simulator Comment workflow adds the test results as a comment to the corresponding pull request.

This commit makes two changes:

  • Only add a comment on test failure.
  • In case a comment already exists, update it in place.

Parts of #1716.

Note I have not been able to test this yet. Happy to port this over to my test-setup https://github.com/mxinden/quic-interop-runner-action/ though that will take me a bit more time. Your call.

Once the QUIC Network Simulator workflow finished, the QUIC Network Simulator
Comment workflow adds the test results as a comment to the corresponding pull
request.

This commit makes two changes:

- Only add a comment on test failure.
- In case a comment already exists, update it in place.
Copy link
Collaborator

@larseggert larseggert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mxinden
Copy link
Collaborator Author

mxinden commented Mar 7, 2024

Only add a comment on test failure.

Note that the changes will only take effect once this pull request is merged. Thus I still expect a comment to be added to this pull request even if the QUIC Interop tests succeed.

Copy link

github-actions bot commented Mar 7, 2024

QUIC Interop Runner

Saving logs to logs.
Run took 0:03:31.677661
Server: neqo-latest. Client: neqo-latest. Running test case: handshake
Server: quic-go. Client: neqo-latest. Running test case: handshake
Server: ngtcp2. Client: neqo-latest. Running test case: handshake
Server: neqo. Client: neqo-latest. Running test case: handshake
Server: msquic. Client: neqo-latest. Running test case: handshake
Server: neqo-latest. Client: quic-go. Running test case: handshake
Server: neqo-latest. Client: ngtcp2. Running test case: handshake
Server: neqo-latest. Client: neqo. Running test case: handshake
Server: neqo-latest. Client: msquic. Running test case: handshake
+-------------+-------------+---------+--------+------+--------+
|             | neqo-latest | quic-go | ngtcp2 | neqo | msquic |
+-------------+-------------+---------+--------+------+--------+
| neqo-latest |     ✓(H)    |   ✓(H)  |  ✓(H)  | ✓(H) |  ✓(H)  |
|             |     ?()     |   ?()   |  ?()   | ?()  |  ?()   |
|             |     ✕()     |   ✕()   |  ✕()   | ✕()  |  ✕()   |
+-------------+-------------+---------+--------+------+--------+
|   quic-go   |     ✓(H)    |         |        |      |        |
|             |     ?()     |         |        |      |        |
|             |     ✕()     |         |        |      |        |
+-------------+-------------+---------+--------+------+--------+
|    ngtcp2   |     ✓(H)    |         |        |      |        |
|             |     ?()     |         |        |      |        |
|             |     ✕()     |         |        |      |        |
+-------------+-------------+---------+--------+------+--------+
|     neqo    |     ✓(H)    |         |        |      |        |
|             |     ?()     |         |        |      |        |
|             |     ✕()     |         |        |      |        |
+-------------+-------------+---------+--------+------+--------+
|    msquic   |     ✓(H)    |         |        |      |        |
|             |     ?()     |         |        |      |        |
|             |     ✕()     |         |        |      |        |
+-------------+-------------+---------+--------+------+--------+

Download artifacts here.

@larseggert larseggert added this pull request to the merge queue Mar 7, 2024
Copy link

codecov bot commented Mar 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.98%. Comparing base (1a7e8fe) to head (8eb1c7b).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1720   +/-   ##
=======================================
  Coverage   92.98%   92.98%           
=======================================
  Files         120      120           
  Lines       37399    37399           
=======================================
  Hits        34775    34775           
  Misses       2624     2624           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Merged via the queue into mozilla:main with commit a59fe0c Mar 7, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants