Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Make criterion calculate transfer benchmark throughputs #1738

Merged
merged 7 commits into from
Mar 16, 2024
Merged

test: Make criterion calculate transfer benchmark throughputs #1738

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
9ae3016
test: Make `criterion` calculate transfer benchmark throughputs
larseggert Mar 13, 2024
2a1a1e6
Merge branch 'main' into perf-bench-thrpt
larseggert Mar 13, 2024
53270a5
Merge branch 'main' into perf-bench-thrpt
larseggert Mar 14, 2024
12a0d9c
Merge branch 'main' into perf-bench-thrpt
larseggert Mar 14, 2024
9dbef37
Merge branch 'main' into perf-bench-thrpt
larseggert Mar 14, 2024
4b04ca1
Merge branch 'main' into perf-bench-thrpt
larseggert Mar 14, 2024
9f6d5e5
This doesn't actually run `cargo bench`, it runs `cargo flamegraph`
larseggert Mar 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions neqo-transport/benches/transfer.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@

use std::time::Duration;

use criterion::{criterion_group, criterion_main, BatchSize::SmallInput, Criterion};
use criterion::{criterion_group, criterion_main, BatchSize::SmallInput, Criterion, Throughput};
use test_fixture::{
boxed,
sim::{
Expand All @@ -21,7 +21,9 @@ const JITTER: Duration = Duration::from_millis(10);
const TRANSFER_AMOUNT: usize = 1 << 22; // 4Mbyte

fn benchmark_transfer(c: &mut Criterion, label: &str, seed: Option<impl AsRef<str>>) {
c.bench_function(label, |b| {
let mut group = c.benchmark_group("transfer");
group.throughput(Throughput::Bytes(u64::try_from(TRANSFER_AMOUNT).unwrap()));
group.bench_function(label, |b| {
b.iter_batched(
|| {
let nodes = boxed![
Expand All @@ -44,6 +46,7 @@ fn benchmark_transfer(c: &mut Criterion, label: &str, seed: Option<impl AsRef<st
SmallInput,
)
});
group.finish();
}

fn benchmark_transfer_variable(c: &mut Criterion) {
Expand Down
Loading