Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(github/interop): use grep instead of awk #1747

Merged
merged 3 commits into from
Mar 26, 2024

Conversation

mxinden
Copy link
Collaborator

@mxinden mxinden commented Mar 15, 2024

Follow-up to #1743 (comment).

Copy link

codecov bot commented Mar 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.48%. Comparing base (f2733e4) to head (ffa25a1).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1747   +/-   ##
=======================================
  Coverage   89.48%   89.48%           
=======================================
  Files         126      126           
  Lines       38866    38866           
=======================================
  Hits        34780    34780           
  Misses       4086     4086           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Mar 15, 2024

Benchmark results

Performance differences relative to 76630a5.

  • drain a timer quickly time: [391.20 ns 398.64 ns 405.63 ns]
    change: [-1.4826% +0.0916% +1.8179%] (p = 0.92 > 0.05)
    No change in performance detected.

  • coalesce_acked_from_zero 1+1 entries
    time: [194.13 ns 194.55 ns 194.99 ns]
    change: [-0.3957% +0.0665% +0.5379%] (p = 0.79 > 0.05)
    No change in performance detected.

  • coalesce_acked_from_zero 3+1 entries
    time: [233.63 ns 234.14 ns 234.70 ns]
    change: [-1.6754% -1.1301% -0.4253%] (p = 0.00 < 0.05)
    Change within noise threshold.

  • coalesce_acked_from_zero 10+1 entries
    time: [233.68 ns 234.58 ns 235.64 ns]
    change: [-1.5220% -0.9632% -0.4017%] (p = 0.00 < 0.05)
    Change within noise threshold.

  • coalesce_acked_from_zero 1000+1 entries
    time: [213.03 ns 213.26 ns 213.52 ns]
    change: [-0.4340% +0.3842% +1.1320%] (p = 0.35 > 0.05)
    No change in performance detected.

  • RxStreamOrderer::inbound_frame()
    time: [117.80 ms 117.88 ms 117.96 ms]
    change: [+0.2903% +0.3939% +0.4903%] (p = 0.00 < 0.05)
    Change within noise threshold.

  • transfer/Run multiple transfers with varying seeds
    time: [117.63 ms 117.90 ms 118.17 ms]
    thrpt: [33.849 MiB/s 33.927 MiB/s 34.005 MiB/s]
    change:
    time: [-0.2391% +0.0853% +0.4236%] (p = 0.60 > 0.05)
    thrpt: [-0.4218% -0.0852% +0.2397%]
    No change in performance detected.

  • transfer/Run multiple transfers with the same seed
    time: [118.49 ms 118.64 ms 118.79 ms]
    thrpt: [33.672 MiB/s 33.715 MiB/s 33.760 MiB/s]
    change:
    time: [-0.0525% +0.1356% +0.3212%] (p = 0.17 > 0.05)
    thrpt: [-0.3201% -0.1354% +0.0525%]
    No change in performance detected.

Client/server transfer results

Transfer of 134217728 bytes over loopback.

Client Server CC Pacing Mean [ms] Min [ms] Max [ms] Relative
msquic msquic 734.5 ± 278.6 383.2 1254.2 1.00
neqo msquic reno on 1978.6 ± 91.6 1890.7 2168.2 1.00
neqo msquic reno 2175.1 ± 227.4 1899.7 2513.8 1.00
neqo msquic cubic on 2108.3 ± 296.7 1888.7 2609.5 1.00
neqo msquic cubic 2029.2 ± 230.8 1882.1 2480.3 1.00
msquic neqo reno on 4469.3 ± 264.2 4193.3 5144.1 1.00
msquic neqo reno 4422.2 ± 273.0 4120.6 4996.1 1.00
msquic neqo cubic on 4495.7 ± 263.9 4182.6 5130.3 1.00
msquic neqo cubic 4490.8 ± 242.5 4150.1 4987.8 1.00
neqo neqo reno on 3820.9 ± 146.6 3507.0 4025.3 1.00
neqo neqo reno 3915.9 ± 206.5 3633.4 4270.9 1.00
neqo neqo cubic on 4285.8 ± 445.6 3087.3 4666.8 1.00
neqo neqo cubic 4308.9 ± 217.7 4003.4 4705.3 1.00

⬇️ Download logs

auto-merge was automatically disabled March 26, 2024 15:22

Head branch was pushed to by a user without write access

@larseggert larseggert added this pull request to the merge queue Mar 26, 2024
Merged via the queue into mozilla:main with commit 57dd4ec Mar 26, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants