Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Enable "fat" LTO for release builds #1751

Merged
merged 2 commits into from
Mar 16, 2024

Conversation

larseggert
Copy link
Collaborator

@larseggert larseggert added this pull request to the merge queue Mar 16, 2024
Copy link

codecov bot commented Mar 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.48%. Comparing base (83e6733) to head (b248127).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1751   +/-   ##
=======================================
  Coverage   89.48%   89.48%           
=======================================
  Files         126      126           
  Lines       38866    38866           
=======================================
  Hits        34780    34780           
  Misses       4086     4086           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Benchmark results

Performance differences relative to 2750423.

  • coalesce_acked_from_zero 1+1 entries
    time: [192.15 ns 192.66 ns 193.22 ns]
    change: [-24.872% -24.546% -24.199%] (p = 0.00 < 0.05)
    💚 Performance has improved.

  • coalesce_acked_from_zero 3+1 entries
    time: [233.63 ns 234.27 ns 234.92 ns]
    change: [-20.095% -19.819% -19.540%] (p = 0.00 < 0.05)
    💚 Performance has improved.

  • coalesce_acked_from_zero 10+1 entries
    time: [234.17 ns 235.59 ns 237.47 ns]
    change: [-20.170% -17.242% -11.811%] (p = 0.00 < 0.05)
    💚 Performance has improved.

  • coalesce_acked_from_zero 1000+1 entries
    time: [216.42 ns 216.80 ns 217.27 ns]
    change: [-19.522% -19.011% -18.469%] (p = 0.00 < 0.05)
    💚 Performance has improved.

  • RxStreamOrderer::inbound_frame()
    time: [120.85 ms 121.01 ms 121.26 ms]
    change: [-5.0953% -4.8773% -4.6604%] (p = 0.00 < 0.05)
    💚 Performance has improved.

  • transfer/Run multiple transfers with varying seeds
    time: [119.75 ms 120.03 ms 120.31 ms]
    thrpt: [33.248 MiB/s 33.325 MiB/s 33.403 MiB/s]

  • transfer/Run multiple transfers with the same seed
    time: [120.81 ms 120.98 ms 121.18 ms]
    thrpt: [33.010 MiB/s 33.064 MiB/s 33.111 MiB/s]

⬇️ Download logs

Merged via the queue into mozilla:main with commit 9ff3751 Mar 16, 2024
15 checks passed
@larseggert larseggert deleted the build-lto branch March 16, 2024 05:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants