Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Run a daily baseline benchmark of main for the cache #1770

Merged
merged 1 commit into from
Mar 25, 2024

Conversation

larseggert
Copy link
Collaborator

@larseggert larseggert commented Mar 23, 2024

The docker and python caches put quite a bit of stress on the GHA cache, causing it - for example - to time out the benchmark results too soon. See https://github.com/mozilla/neqo/actions/caches

This makes sure we should have a fresh baseline benchmark in the cache for comparison.

Simpler than #1769

Copy link

codecov bot commented Mar 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.09%. Comparing base (bb3ab60) to head (bf6b51a).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1770   +/-   ##
=======================================
  Coverage   93.09%   93.09%           
=======================================
  Files         117      117           
  Lines       36404    36404           
=======================================
  Hits        33889    33889           
  Misses       2515     2515           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Benchmark results

Performance differences relative to bb3ab60.

  • coalesce_acked_from_zero 1+1 entries
    time: [195.40 ns 195.81 ns 196.28 ns]
    change: [-0.7095% -0.3470% -0.0194%] (p = 0.05 > 0.05)
    No change in performance detected.

  • coalesce_acked_from_zero 3+1 entries
    time: [235.78 ns 236.30 ns 236.87 ns]
    change: [-0.0453% +0.5634% +1.4457%] (p = 0.16 > 0.05)
    No change in performance detected.

  • coalesce_acked_from_zero 10+1 entries
    time: [235.02 ns 236.00 ns 237.08 ns]
    change: [-0.7700% -0.2568% +0.2179%] (p = 0.32 > 0.05)
    No change in performance detected.

  • coalesce_acked_from_zero 1000+1 entries
    time: [216.76 ns 216.94 ns 217.15 ns]
    change: [+0.3124% +1.0214% +1.6930%] (p = 0.00 < 0.05)
    Change within noise threshold.

  • RxStreamOrderer::inbound_frame()
    time: [117.97 ms 118.04 ms 118.11 ms]
    change: [-0.4944% -0.4023% -0.3111%] (p = 0.00 < 0.05)
    Change within noise threshold.

  • transfer/Run multiple transfers with varying seeds
    time: [117.58 ms 117.86 ms 118.12 ms]
    thrpt: [33.863 MiB/s 33.940 MiB/s 34.019 MiB/s]
    change:
    time: [-0.7026% -0.3848% -0.0561%] (p = 0.02 < 0.05)
    thrpt: [+0.0561% +0.3862% +0.7076%]
    Change within noise threshold.

  • transfer/Run multiple transfers with the same seed
    time: [118.15 ms 118.32 ms 118.48 ms]
    thrpt: [33.760 MiB/s 33.808 MiB/s 33.856 MiB/s]
    change:
    time: [-0.5884% -0.3850% -0.1878%] (p = 0.00 < 0.05)
    thrpt: [+0.1881% +0.3865% +0.5919%]
    Change within noise threshold.

⬇️ Download logs

@larseggert larseggert added this pull request to the merge queue Mar 25, 2024
Merged via the queue into main with commit 6691c1a Mar 25, 2024
18 checks passed
@larseggert larseggert deleted the ci-daily-baseline branch March 25, 2024 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants