Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Enable the ossf/scorecard action #1776

Merged
merged 1 commit into from
Mar 28, 2024
Merged

ci: Enable the ossf/scorecard action #1776

merged 1 commit into from
Mar 28, 2024

Conversation

larseggert
Copy link
Collaborator

@larseggert larseggert commented Mar 27, 2024

Let's see what this will report on our code...

Let's see what this will report on our code...

Signed-off-by: Lars Eggert <lars@eggert.org>
@larseggert larseggert changed the title Enable the ossf/scorecard action Enable the ossf/scorecard action Mar 27, 2024
Copy link

codecov bot commented Mar 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.07%. Comparing base (37be894) to head (f736301).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1776   +/-   ##
=======================================
  Coverage   93.07%   93.07%           
=======================================
  Files         117      117           
  Lines       36449    36449           
=======================================
  Hits        33926    33926           
  Misses       2523     2523           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Benchmark results

Performance differences relative to 1af91f5.

  • drain a timer quickly time: [394.43 ns 401.64 ns 408.02 ns]
    change: [-1.7052% +0.1125% +1.9184%] (p = 0.90 > 0.05)
    No change in performance detected.

  • coalesce_acked_from_zero 1+1 entries
    time: [197.58 ns 198.07 ns 198.61 ns]
    change: [+1.2098% +1.6241% +1.9727%] (p = 0.00 < 0.05)
    💔 Performance has regressed.

  • coalesce_acked_from_zero 3+1 entries
    time: [238.26 ns 238.85 ns 239.49 ns]
    change: [+1.8739% +2.2497% +2.6369%] (p = 0.00 < 0.05)
    💔 Performance has regressed.

  • coalesce_acked_from_zero 10+1 entries
    time: [236.64 ns 237.12 ns 237.77 ns]
    change: [+0.4972% +1.1080% +1.7202%] (p = 0.00 < 0.05)
    Change within noise threshold.

  • coalesce_acked_from_zero 1000+1 entries
    time: [213.22 ns 221.78 ns 240.67 ns]
    change: [-0.9106% +1.4733% +5.3256%] (p = 0.52 > 0.05)
    No change in performance detected.

  • RxStreamOrderer::inbound_frame()
    time: [117.72 ms 117.81 ms 117.89 ms]
    change: [-0.3336% -0.2361% -0.1331%] (p = 0.00 < 0.05)
    Change within noise threshold.

  • transfer/Run multiple transfers with varying seeds
    time: [118.97 ms 119.27 ms 119.57 ms]
    thrpt: [33.453 MiB/s 33.537 MiB/s 33.623 MiB/s]
    change:
    time: [+1.9398% +2.2308% +2.5246%] (p = 0.00 < 0.05)
    thrpt: [-2.4625% -2.1821% -1.9029%]
    Change within noise threshold.

  • transfer/Run multiple transfers with the same seed
    time: [120.01 ms 120.18 ms 120.35 ms]
    thrpt: [33.235 MiB/s 33.284 MiB/s 33.331 MiB/s]
    change:
    time: [+2.3283% +2.5122% +2.7170%] (p = 0.00 < 0.05)
    thrpt: [-2.6452% -2.4507% -2.2753%]
    Change within noise threshold.

Client/server transfer results

Transfer of 134217728 bytes over loopback.

Client Server CC Pacing Mean [ms] Min [ms] Max [ms] Relative
msquic msquic 776.9 ± 275.8 372.2 1290.1 1.00
neqo msquic reno on 2011.3 ± 197.8 1868.8 2452.7 1.00
neqo msquic reno 2032.5 ± 235.7 1823.3 2498.3 1.00
neqo msquic cubic on 2121.5 ± 281.8 1821.2 2593.5 1.00
neqo msquic cubic 1957.4 ± 143.2 1829.3 2351.7 1.00
msquic neqo reno on 4468.0 ± 283.3 4219.4 5145.2 1.00
msquic neqo reno 4525.7 ± 266.3 4128.7 5015.4 1.00
msquic neqo cubic on 4464.5 ± 206.8 4085.1 4817.2 1.00
msquic neqo cubic 4503.6 ± 256.9 4195.2 5141.3 1.00
neqo neqo reno on 3751.6 ± 148.0 3599.0 4056.3 1.00
neqo neqo reno 3338.6 ± 114.4 3193.1 3571.1 1.00
neqo neqo cubic on 4411.2 ± 315.4 3837.1 4971.2 1.00
neqo neqo cubic 4214.7 ± 410.8 3224.1 4628.4 1.00

⬇️ Download logs

@larseggert larseggert changed the title Enable the ossf/scorecard action ci: Enable the ossf/scorecard action Mar 27, 2024
@larseggert larseggert added this pull request to the merge queue Mar 28, 2024
Merged via the queue into main with commit f749204 Mar 28, 2024
19 checks passed
@larseggert larseggert deleted the ci-ossf-scorecard branch March 28, 2024 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants