Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Fix clippy nightly warnings #1853

Merged
merged 1 commit into from
Apr 29, 2024
Merged

Conversation

larseggert
Copy link
Collaborator

No description provided.

Copy link

QUIC Interop Runner

neqo-latest quic-go ngtcp2 neqo msquic
neqo-latest ✅(H,E,U,R)
?()
❌()
✅(H,U,R)
?(E)
❌()
✅(H,E,U,R)
?()
❌()
✅(H,E,U,R)
?()
❌()
✅(H,U,R)
?(E)
❌()
quic-go ✅(H,U,R)
?(E)
❌()
ngtcp2 ✅(H,E,U,R)
?()
❌()
neqo ✅(H,E,U,R)
?()
❌()
msquic ✅(H,U,R)
?(E)
❌()

⬇️ Download logs

Copy link

Benchmark results

Performance differences relative to bb42d14.

  • drain a timer quickly time: [322.01 ns 330.07 ns 337.44 ns]
    change: [-2.9929% -0.7569% +1.2442%] (p = 0.50 > 0.05)
    No change in performance detected.

  • coalesce_acked_from_zero 1+1 entries
    time: [199.17 ns 199.70 ns 200.27 ns]
    change: [-0.1375% +0.2127% +0.5901%] (p = 0.26 > 0.05)
    No change in performance detected.

  • coalesce_acked_from_zero 3+1 entries
    time: [241.32 ns 241.96 ns 242.68 ns]
    change: [-0.2051% +0.1030% +0.3839%] (p = 0.51 > 0.05)
    No change in performance detected.

  • coalesce_acked_from_zero 10+1 entries
    time: [240.68 ns 241.54 ns 242.55 ns]
    change: [-0.7081% +0.2897% +1.5600%] (p = 0.64 > 0.05)
    No change in performance detected.

  • coalesce_acked_from_zero 1000+1 entries
    time: [216.97 ns 217.22 ns 217.51 ns]
    change: [-0.4506% +0.2620% +1.0309%] (p = 0.51 > 0.05)
    No change in performance detected.

  • RxStreamOrderer::inbound_frame()
    time: [119.39 ms 119.51 ms 119.64 ms]
    change: [+0.6282% +0.7735% +0.9188%] (p = 0.00 < 0.05)
    Change within noise threshold.

  • transfer/Run multiple transfers with varying seeds
    time: [119.20 ms 119.48 ms 119.76 ms]
    thrpt: [33.401 MiB/s 33.478 MiB/s 33.556 MiB/s]
    change:
    time: [+0.6774% +0.9666% +1.2980%] (p = 0.00 < 0.05)
    thrpt: [-1.2814% -0.9574% -0.6728%]
    Change within noise threshold.

  • transfer/Run multiple transfers with the same seed
    time: [119.58 ms 119.73 ms 119.89 ms]
    thrpt: [33.363 MiB/s 33.407 MiB/s 33.452 MiB/s]
    change:
    time: [+0.9081% +1.0955% +1.2859%] (p = 0.00 < 0.05)
    thrpt: [-1.2696% -1.0836% -0.8999%]
    Change within noise threshold.

  • 1-conn/1-100mb-resp (aka. Download)/client
    time: [1.1107 s 1.1139 s 1.1171 s]
    thrpt: [89.516 MiB/s 89.778 MiB/s 90.032 MiB/s]
    change:
    time: [-3.5695% -1.5781% -0.1574%] (p = 0.10 > 0.05)
    thrpt: [+0.1577% +1.6034% +3.7016%]
    No change in performance detected.

  • 1-conn/10_000-parallel-1b-resp (aka. RPS)/client
    time: [430.61 ms 432.55 ms 434.50 ms]
    thrpt: [23.015 Kelem/s 23.119 Kelem/s 23.223 Kelem/s]
    change:
    time: [-0.1702% +0.5116% +1.2510%] (p = 0.16 > 0.05)
    thrpt: [-1.2356% -0.5090% +0.1704%]
    No change in performance detected.

  • 1-conn/1-1b-resp (aka. HPS)/client
    time: [49.063 ms 49.357 ms 49.645 ms]
    thrpt: [20.143 elem/s 20.260 elem/s 20.382 elem/s]
    change:
    time: [+0.1629% +1.3385% +2.5253%] (p = 0.02 < 0.05)
    thrpt: [-2.4631% -1.3208% -0.1626%]
    Change within noise threshold.

Client/server transfer results

Transfer of 134217728 bytes over loopback.

Client Server CC Pacing Mean [ms] Min [ms] Max [ms] Relative
msquic msquic 403.3 ± 35.3 372.6 482.7 1.00
neqo msquic reno on 767.4 ± 11.9 754.3 796.2 1.00
neqo msquic reno 794.5 ± 44.8 751.1 877.2 1.00
neqo msquic cubic on 906.7 ± 220.8 751.3 1500.5 1.00
neqo msquic cubic 787.7 ± 27.6 755.5 852.2 1.00
msquic neqo reno on 4263.6 ± 160.1 3978.2 4507.8 1.00
msquic neqo reno 4295.6 ± 149.2 4091.0 4523.0 1.00
msquic neqo cubic on 4401.6 ± 151.8 4168.2 4634.1 1.00
msquic neqo cubic 4375.9 ± 157.0 4134.0 4567.2 1.00
neqo neqo reno on 3618.6 ± 446.4 3011.2 4418.5 1.00
neqo neqo reno 3400.7 ± 246.4 3006.1 3742.3 1.00
neqo neqo cubic on 4129.7 ± 404.6 3094.0 4445.9 1.00
neqo neqo cubic 3917.2 ± 568.2 2792.2 4389.0 1.00

⬇️ Download logs

neqo-crypto/src/aead_null.rs Show resolved Hide resolved
neqo-crypto/src/constants.rs Show resolved Hide resolved
neqo-crypto/src/constants.rs Show resolved Hide resolved
@larseggert larseggert added this pull request to the merge queue Apr 29, 2024
Merged via the queue into mozilla:main with commit b18a614 Apr 29, 2024
13 checks passed
@larseggert larseggert deleted the chore-clippy branch April 29, 2024 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants