Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Bump MSRV to 1.76 #1865

Merged
merged 2 commits into from
May 2, 2024
Merged

Conversation

larseggert
Copy link
Collaborator

Gecko did two days ago

Gecko did two days ago
Copy link

github-actions bot commented May 2, 2024

Failed Interop Tests

QUIC Interop Runner, client vs. server

Succeeded and unsupported tests

Succeeded Interop Tests

Unsupported Interop Tests

Copy link

codecov bot commented May 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.25%. Comparing base (14cafba) to head (79ab4d8).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1865   +/-   ##
=======================================
  Coverage   93.25%   93.25%           
=======================================
  Files         110      110           
  Lines       35813    35813           
=======================================
  Hits        33397    33397           
  Misses       2416     2416           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented May 2, 2024

Benchmark results

Performance differences relative to 14cafba.

  • drain a timer quickly time: [309.68 ns 318.29 ns 326.23 ns]
    change: [-2.4547% +0.2804% +2.8308%] (p = 0.84 > 0.05)
    No change in performance detected.

  • coalesce_acked_from_zero 1+1 entries
    time: [193.61 ns 194.10 ns 194.62 ns]
    change: [-0.5604% +0.2308% +1.4770%] (p = 0.76 > 0.05)
    No change in performance detected.

  • coalesce_acked_from_zero 3+1 entries
    time: [236.64 ns 237.26 ns 237.91 ns]
    change: [-1.3048% -0.4502% +0.1642%] (p = 0.28 > 0.05)
    No change in performance detected.

  • coalesce_acked_from_zero 10+1 entries
    time: [235.47 ns 236.46 ns 237.55 ns]
    change: [-0.3866% +0.2021% +0.8071%] (p = 0.55 > 0.05)
    No change in performance detected.

  • coalesce_acked_from_zero 1000+1 entries
    time: [218.08 ns 218.28 ns 218.51 ns]
    change: [-0.6015% +0.0398% +0.6588%] (p = 0.91 > 0.05)
    No change in performance detected.

  • RxStreamOrderer::inbound_frame()
    time: [117.94 ms 118.03 ms 118.13 ms]
    change: [-0.7298% -0.6087% -0.4856%] (p = 0.00 < 0.05)
    Change within noise threshold.

  • transfer/Run multiple transfers with varying seeds
    time: [117.25 ms 117.52 ms 117.78 ms]
    thrpt: [33.960 MiB/s 34.037 MiB/s 34.116 MiB/s]
    change:
    time: [-1.5654% -1.2414% -0.9162%] (p = 0.00 < 0.05)
    thrpt: [+0.9246% +1.2570% +1.5903%]
    Change within noise threshold.

  • transfer/Run multiple transfers with the same seed
    time: [117.17 ms 117.42 ms 117.68 ms]
    thrpt: [33.991 MiB/s 34.065 MiB/s 34.139 MiB/s]
    change:
    time: [-1.8572% -1.5615% -1.2980%] (p = 0.00 < 0.05)
    thrpt: [+1.3151% +1.5863% +1.8923%]
    Change within noise threshold.

  • 1-conn/1-100mb-resp (aka. Download)/client
    time: [1.0971 s 1.1103 s 1.1267 s]
    thrpt: [88.755 MiB/s 90.066 MiB/s 91.146 MiB/s]
    change:
    time: [-2.9777% -1.7630% -0.3536%] (p = 0.03 < 0.05)
    thrpt: [+0.3549% +1.7946% +3.0691%]
    Change within noise threshold.

  • 1-conn/10_000-parallel-1b-resp (aka. RPS)/client
    time: [429.25 ms 431.31 ms 433.43 ms]
    thrpt: [23.072 Kelem/s 23.185 Kelem/s 23.296 Kelem/s]
    change:
    time: [+0.7389% +1.4714% +2.2256%] (p = 0.00 < 0.05)
    thrpt: [-2.1772% -1.4501% -0.7335%]
    Change within noise threshold.

  • 1-conn/1-1b-resp (aka. HPS)/client
    time: [48.005 ms 48.437 ms 48.853 ms]
    thrpt: [20.470 elem/s 20.645 elem/s 20.831 elem/s]
    change:
    time: [-2.3662% -1.1673% -0.0156%] (p = 0.05 > 0.05)
    thrpt: [+0.0156% +1.1811% +2.4236%]
    No change in performance detected.

Client/server transfer results

Transfer of 134217728 bytes over loopback.

Client Server CC Pacing Mean [ms] Min [ms] Max [ms] Relative
msquic msquic 612.6 ± 247.1 408.1 1064.4 1.00
neqo msquic reno on 1009.8 ± 294.6 767.7 1600.0 1.00
neqo msquic reno 873.5 ± 147.3 739.4 1116.2 1.00
neqo msquic cubic on 909.4 ± 170.8 773.4 1290.9 1.00
neqo msquic cubic 833.9 ± 108.0 754.3 1128.9 1.00
msquic neqo reno on 4336.9 ± 163.1 4125.2 4586.5 1.00
msquic neqo reno 4311.7 ± 259.1 4026.6 4926.0 1.00
msquic neqo cubic on 4404.5 ± 197.4 4173.2 4784.8 1.00
msquic neqo cubic 4476.7 ± 250.4 4210.8 5050.5 1.00
neqo neqo reno on 3350.3 ± 214.5 3022.5 3691.0 1.00
neqo neqo reno 3432.2 ± 172.6 3049.5 3619.1 1.00
neqo neqo cubic on 4000.7 ± 552.5 2695.3 4754.9 1.00
neqo neqo cubic 4227.5 ± 329.1 3617.4 4926.4 1.00

⬇️ Download logs

@larseggert larseggert enabled auto-merge May 2, 2024 09:13
@larseggert larseggert added this pull request to the merge queue May 2, 2024
Merged via the queue into mozilla:main with commit 8c4411a May 2, 2024
50 checks passed
@larseggert larseggert deleted the chore-msrv-1.76 branch May 2, 2024 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants