-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: enable mozilla-central http3server to use neqo-bin #1878
Merged
larseggert
merged 8 commits into
mozilla:main
from
mxinden:merge-moz-central-http3-server
May 8, 2024
Merged
refactor: enable mozilla-central http3server to use neqo-bin #1878
larseggert
merged 8 commits into
mozilla:main
from
mxinden:merge-moz-central-http3-server
May 8, 2024
Commits on May 3, 2024
-
refactor(bin): introduce server/http3.rs and server/http09.rs
The QUIC Interop Runner requires an http3 and http09 implementation for both client and server. The client code is already structured into an http3 and an http09 implementation since mozilla#1727. This commit does the same for the server side, i.e. splits the http3 and http09 implementation into separate Rust modules.
Configuration menu - View commit details
-
Copy full SHA for ae5cbf5 - Browse repository at this point
Copy the full SHA ae5cbf5View commit details
Commits on May 4, 2024
-
refactor: merge mozilla-central http3 server into neqo-bin
There are two server implementations based on neqo: 1. https://github.com/mozilla/neqo/tree/main/neqo-bin/src/server - http3 and http09 implementation - used for manual testing and QUIC Interop 2. https://searchfox.org/mozilla-central/source/netwerk/test/http3server/src/main.rs - used to test Firefox I assume one was once an exact copy of the other. Both implement their own I/O, event loop, ... Since then, the two implementations diverged significantly. Especially (1) saw a lot of improvements in recent months: - mozilla#1564 - mozilla#1569 - mozilla#1578 - mozilla#1581 - mozilla#1604 - mozilla#1612 - mozilla#1676 - mozilla#1692 - mozilla#1707 - mozilla#1708 - mozilla#1727 - mozilla#1753 - mozilla#1756 - mozilla#1766 - mozilla#1772 - mozilla#1786 - mozilla#1787 - mozilla#1788 - mozilla#1794 - mozilla#1806 - mozilla#1808 - mozilla#1848 - mozilla#1866 At this point, bugs in (2) are hard to fix, see e.g. mozilla#1801. This commit merges (2) into (1), thus removing all duplicate logic and having (2) benefit from all the recent improvements to (1).
Configuration menu - View commit details
-
Copy full SHA for 98b969e - Browse repository at this point
Copy the full SHA 98b969eView commit details
Commits on May 6, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 733d97e - Browse repository at this point
Copy the full SHA 733d97eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 190bb75 - Browse repository at this point
Copy the full SHA 190bb75View commit details -
Configuration menu - View commit details
-
Copy full SHA for ad9e881 - Browse repository at this point
Copy the full SHA ad9e881View commit details -
Configuration menu - View commit details
-
Copy full SHA for e7ff2df - Browse repository at this point
Copy the full SHA e7ff2dfView commit details
Commits on May 7, 2024
-
Merge branch 'main' of https://github.com/mozilla/neqo into merge-moz…
…-central-http3-server
Configuration menu - View commit details
-
Copy full SHA for ee65cae - Browse repository at this point
Copy the full SHA ee65caeView commit details -
Nice to have. Adds multiple dependencies. Hard to justify for mozilla-central.
Configuration menu - View commit details
-
Copy full SHA for 955aaa9 - Browse repository at this point
Copy the full SHA 955aaa9View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.