Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Fix the fuzz targets #1972

Merged
merged 6 commits into from
Jul 12, 2024
Merged

ci: Fix the fuzz targets #1972

merged 6 commits into from
Jul 12, 2024

Conversation

larseggert
Copy link
Collaborator

And check them during CI, so they keep building.

And check them during CI, so they keep building.
Copy link

github-actions bot commented Jul 11, 2024

Failed Interop Tests

QUIC Interop Runner, client vs. server

All results

Succeeded Interop Tests

QUIC Interop Runner, client vs. server

Unsupported Interop Tests

QUIC Interop Runner, client vs. server

@larseggert larseggert marked this pull request as ready for review July 11, 2024 06:51
Copy link

codecov bot commented Jul 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.97%. Comparing base (4852dc6) to head (90d9097).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1972   +/-   ##
=======================================
  Coverage   94.97%   94.97%           
=======================================
  Files         112      112           
  Lines       36509    36509           
=======================================
  Hits        34673    34673           
  Misses       1836     1836           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Benchmark results

Performance differences relative to 4852dc6.

coalesce_acked_from_zero 1+1 entries: No change in performance detected.
       time:   [192.51 ns 192.98 ns 193.47 ns]
       change: [-0.5079% -0.0928% +0.3330%] (p = 0.67 > 0.05)

Found 6 outliers among 100 measurements (6.00%)
3 (3.00%) high mild
3 (3.00%) high severe

coalesce_acked_from_zero 3+1 entries: 💔 Performance has regressed.
       time:   [237.51 ns 238.12 ns 238.75 ns]
       change: [+1.4835% +1.8656% +2.2640%] (p = 0.00 < 0.05)

Found 19 outliers among 100 measurements (19.00%)
1 (1.00%) low severe
4 (4.00%) low mild
1 (1.00%) high mild
13 (13.00%) high severe

coalesce_acked_from_zero 10+1 entries: 💔 Performance has regressed.
       time:   [238.68 ns 239.57 ns 240.64 ns]
       change: [+1.4212% +2.2228% +2.9766%] (p = 0.00 < 0.05)

Found 12 outliers among 100 measurements (12.00%)
1 (1.00%) high mild
11 (11.00%) high severe

coalesce_acked_from_zero 1000+1 entries: Change within noise threshold.
       time:   [216.89 ns 217.09 ns 217.29 ns]
       change: [+0.1996% +0.8238% +1.5664%] (p = 0.02 < 0.05)

Found 11 outliers among 100 measurements (11.00%)
2 (2.00%) high mild
9 (9.00%) high severe

RxStreamOrderer::inbound_frame(): No change in performance detected.
       time:   [119.23 ms 119.41 ms 119.69 ms]
       change: [-0.3909% -0.1102% +0.1494%] (p = 0.49 > 0.05)

Found 5 outliers among 100 measurements (5.00%)
4 (4.00%) high mild
1 (1.00%) high severe

transfer/Run multiple transfers with varying seeds: No change in performance detected.
       time:   [55.069 ms 58.228 ms 61.368 ms]
       thrpt:  [65.181 MiB/s 68.695 MiB/s 72.637 MiB/s]
change:
       time:   [-7.9358% -0.4301% +7.7455%] (p = 0.91 > 0.05)
       thrpt:  [-7.1887% +0.4320% +8.6199%]
transfer/Run multiple transfers with the same seed: Change within noise threshold.
       time:   [73.822 ms 80.434 ms 86.940 ms]
       thrpt:  [46.009 MiB/s 49.730 MiB/s 54.184 MiB/s]
change:
       time:   [+0.9272% +14.503% +28.118%] (p = 0.03 < 0.05)
       thrpt:  [-21.947% -12.666% -0.9187%]

Found 8 outliers among 100 measurements (8.00%)
8 (8.00%) low mild

1-conn/1-100mb-resp (aka. Download)/client: No change in performance detected.
       time:   [151.54 ms 163.66 ms 172.15 ms]
       thrpt:  [580.89 MiB/s 611.02 MiB/s 659.88 MiB/s]
change:
       time:   [-2.5532% +1.3531% +6.2049%] (p = 0.57 > 0.05)
       thrpt:  [-5.8424% -1.3350% +2.6201%]

Found 1 outliers among 10 measurements (10.00%)
1 (10.00%) high mild

1-conn/10_000-parallel-1b-resp (aka. RPS)/client: No change in performance detected.
       time:   [431.47 ms 434.78 ms 438.16 ms]
       thrpt:  [22.823 Kelem/s 23.000 Kelem/s 23.176 Kelem/s]
change:
       time:   [-1.2434% -0.1529% +1.0120%] (p = 0.79 > 0.05)
       thrpt:  [-1.0018% +0.1531% +1.2591%]

Found 1 outliers among 100 measurements (1.00%)
1 (1.00%) high mild

1-conn/1-1b-resp (aka. HPS)/client: No change in performance detected.
       time:   [43.452 ms 44.018 ms 44.601 ms]
       thrpt:  [22.421  elem/s 22.718  elem/s 23.014  elem/s]
change:
       time:   [-2.1563% -0.4352% +1.3914%] (p = 0.65 > 0.05)
       thrpt:  [-1.3723% +0.4371% +2.2039%]

Client/server transfer results

Transfer of 33554432 bytes over loopback.

Client Server CC Pacing Mean [ms] Min [ms] Max [ms] Relative
msquic msquic 149.6 ± 73.8 86.8 396.3 1.00
neqo msquic reno on 276.4 ± 11.4 260.8 295.1 1.00
neqo msquic reno 305.5 ± 70.5 262.9 470.1 1.00
neqo msquic cubic on 269.3 ± 8.0 262.4 285.7 1.00
neqo msquic cubic 270.8 ± 9.7 262.2 293.0 1.00
msquic neqo reno on 222.5 ± 158.2 121.6 636.4 1.00
msquic neqo reno 161.2 ± 75.0 112.8 374.9 1.00
msquic neqo cubic on 173.9 ± 66.2 113.4 344.4 1.00
msquic neqo cubic 200.0 ± 65.0 124.8 340.3 1.00
neqo neqo reno on 174.7 ± 12.4 156.9 195.4 1.00
neqo neqo reno 187.0 ± 27.0 150.3 246.8 1.00
neqo neqo cubic on 193.7 ± 92.9 133.0 523.8 1.00
neqo neqo cubic 200.1 ± 62.7 155.0 401.8 1.00

⬇️ Download logs

Copy link

Firefox builds for this PR

The following builds are available for testing. Crossed-out builds did not succeed.

@larseggert larseggert added this pull request to the merge queue Jul 12, 2024
Merged via the queue into mozilla:main with commit f1c04d2 Jul 12, 2024
58 checks passed
@larseggert larseggert deleted the fix-fuzz branch July 12, 2024 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants