fix: Don't panic on Windows if GITHUB_WORKFLOW is not set
#2079
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larseggert
requested review from
KershawChang,
martinthomson and
mxinden
as code owners
Failed Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
All resultsSucceeded Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
Unsupported Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
|
mxinden
approved these changes
Aug 28, 2024
martinthomson
approved these changes
Aug 29, 2024
larseggert
changed the title
GITHUB_WORKFLOW is not setGITHUB_WORKFLOW is not set
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2079 +/- ##
=======================================
Coverage 95.36% 95.36%
=======================================
Files 112 112
Lines 36505 36505
=======================================
Hits 34813 34813
Misses 1692 1692 ☔ View full report in Codecov by Sentry. |
Benchmark resultsPerformance differences relative to 9e8d298. coalesce_acked_from_zero 1+1 entries: Change within noise threshold. time: [98.441 ns 98.704 ns 98.972 ns]
change: [-1.1806% -0.7826% -0.3932%] (p = 0.00 < 0.05)
coalesce_acked_from_zero 3+1 entries: No change in performance detected. time: [117.17 ns 117.56 ns 117.98 ns]
change: [-0.8771% -0.2500% +0.3741%] (p = 0.46 > 0.05)
coalesce_acked_from_zero 10+1 entries: No change in performance detected. time: [116.79 ns 117.32 ns 117.92 ns]
change: [-0.8165% -0.4069% -0.0097%] (p = 0.05 > 0.05)
coalesce_acked_from_zero 1000+1 entries: No change in performance detected. time: [97.079 ns 102.70 ns 114.97 ns]
change: [-1.8355% +1.0826% +5.1256%] (p = 0.70 > 0.05)
RxStreamOrderer::inbound_frame(): No change in performance detected. time: [111.32 ms 111.46 ms 111.67 ms]
change: [-0.0718% +0.0595% +0.2376%] (p = 0.61 > 0.05)
transfer/pacing-false/varying-seeds: Change within noise threshold. time: [27.553 ms 28.432 ms 29.306 ms]
change: [+0.3995% +5.4525% +10.775%] (p = 0.04 < 0.05)
transfer/pacing-true/varying-seeds: No change in performance detected. time: [33.246 ms 34.742 ms 36.256 ms]
change: [-10.242% -4.4470% +1.9115%] (p = 0.17 > 0.05)
transfer/pacing-false/same-seed: No change in performance detected. time: [31.448 ms 32.149 ms 32.826 ms]
change: [-2.6994% +0.1189% +3.0364%] (p = 0.93 > 0.05)
transfer/pacing-true/same-seed: No change in performance detected. time: [40.480 ms 43.327 ms 46.203 ms]
change: [-10.092% -0.8001% +10.356%] (p = 0.88 > 0.05)
1-conn/1-100mb-resp (aka. Download)/client: No change in performance detected. time: [113.49 ms 114.53 ms 115.89 ms]
thrpt: [862.86 MiB/s 873.17 MiB/s 881.12 MiB/s]
change:
time: [-1.3378% -0.3761% +0.7710%] (p = 0.54 > 0.05)
thrpt: [-0.7651% +0.3776% +1.3559%]
1-conn/10_000-parallel-1b-resp (aka. RPS)/client: No change in performance detected. time: [309.41 ms 312.90 ms 316.45 ms]
thrpt: [31.600 Kelem/s 31.959 Kelem/s 32.320 Kelem/s]
change:
time: [-1.5969% -0.0421% +1.6011%] (p = 0.96 > 0.05)
thrpt: [-1.5759% +0.0422% +1.6228%]
1-conn/1-1b-resp (aka. HPS)/client: No change in performance detected. time: [40.517 ms 41.227 ms 41.937 ms]
thrpt: [23.845 elem/s 24.256 elem/s 24.681 elem/s]
change:
time: [-2.3999% -0.0572% +2.3766%] (p = 0.97 > 0.05)
thrpt: [-2.3214% +0.0572% +2.4589%]
Client/server transfer resultsTransfer of 33554432 bytes over loopback.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.