chore: Trim unused features #2090
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Failed Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
All resultsSucceeded Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
Unsupported Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
|
mxinden
reviewed
Sep 6, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2090 +/- ##
==========================================
- Coverage 95.36% 95.33% -0.04%
==========================================
Files 112 112
Lines 36559 36300 -259
==========================================
- Hits 34866 34608 -258
+ Misses 1693 1692 -1 ☔ View full report in Codecov by Sentry. |
Benchmark resultsPerformance differences relative to 28f60bd. coalesce_acked_from_zero 1+1 entries: No change in performance detected. time: [99.614 ns 99.976 ns 100.33 ns]
change: [-0.2703% +0.3692% +0.9348%] (p = 0.25 > 0.05)
coalesce_acked_from_zero 3+1 entries: No change in performance detected. time: [117.25 ns 117.55 ns 117.88 ns]
change: [-0.2873% +0.1360% +0.5234%] (p = 0.53 > 0.05)
coalesce_acked_from_zero 10+1 entries: No change in performance detected. time: [116.92 ns 117.26 ns 117.70 ns]
change: [-0.2510% +0.5829% +1.5478%] (p = 0.21 > 0.05)
coalesce_acked_from_zero 1000+1 entries: No change in performance detected. time: [97.387 ns 97.499 ns 97.632 ns]
change: [-0.7123% +0.1864% +1.2283%] (p = 0.72 > 0.05)
RxStreamOrderer::inbound_frame(): Change within noise threshold. time: [111.53 ms 111.60 ms 111.66 ms]
change: [-0.6310% -0.5543% -0.4820%] (p = 0.00 < 0.05)
transfer/pacing-false/varying-seeds: No change in performance detected. time: [26.807 ms 27.806 ms 28.807 ms]
change: [-4.3948% +0.5521% +5.7756%] (p = 0.84 > 0.05)
transfer/pacing-true/varying-seeds: No change in performance detected. time: [34.348 ms 36.117 ms 37.895 ms]
change: [-11.500% -5.4747% +1.3567%] (p = 0.10 > 0.05)
transfer/pacing-false/same-seed: Change within noise threshold. time: [30.805 ms 31.655 ms 32.474 ms]
change: [-8.0793% -5.0616% -1.5847%] (p = 0.00 < 0.05)
transfer/pacing-true/same-seed: No change in performance detected. time: [42.878 ms 45.226 ms 47.600 ms]
change: [-6.6088% +1.3338% +10.461%] (p = 0.75 > 0.05)
1-conn/1-100mb-resp (aka. Download)/client: 💚 Performance has improved. time: [113.17 ms 113.59 ms 113.99 ms]
thrpt: [877.28 MiB/s 880.38 MiB/s 883.61 MiB/s]
change:
time: [-2.1616% -1.5972% -1.0315%] (p = 0.00 < 0.05)
thrpt: [+1.0423% +1.6232% +2.2094%]
1-conn/10_000-parallel-1b-resp (aka. RPS)/client: Change within noise threshold. time: [311.23 ms 314.79 ms 318.37 ms]
thrpt: [31.410 Kelem/s 31.767 Kelem/s 32.130 Kelem/s]
change:
time: [-3.4718% -1.9131% -0.3548%] (p = 0.01 < 0.05)
thrpt: [+0.3561% +1.9504% +3.5967%]
1-conn/1-1b-resp (aka. HPS)/client: No change in performance detected. time: [32.433 ms 32.619 ms 32.820 ms]
thrpt: [30.469 elem/s 30.657 elem/s 30.833 elem/s]
change:
time: [-0.3533% +0.3505% +1.0219%] (p = 0.33 > 0.05)
thrpt: [-1.0116% -0.3493% +0.3546%]
Client/server transfer resultsTransfer of 33554432 bytes over loopback.
|
larseggert
requested review from
KershawChang and
martinthomson
as code owners
mxinden
approved these changes
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Courtesy of https://github.com/ToBinio/cargo-features-manager.