Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): bump martenseemann/quic-network-simulator-endpoint from 5177120 to f65a034 in /qns #2094

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Sep 9, 2024

Bumps martenseemann/quic-network-simulator-endpoint from 5177120 to f65a034.

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies Pull requests that update a dependency file docker Pull requests that update Docker code labels Sep 9, 2024
Copy link

github-actions bot commented Sep 9, 2024

Failed Interop Tests

QUIC Interop Runner, client vs. server

neqo-latest as client

neqo-latest as server

All results

Succeeded Interop Tests

QUIC Interop Runner, client vs. server

neqo-latest as client

neqo-latest as server

Unsupported Interop Tests

QUIC Interop Runner, client vs. server

neqo-latest as client

neqo-latest as server

Bumps martenseemann/quic-network-simulator-endpoint from `5177120` to `f65a034`.

---
updated-dependencies:
- dependency-name: martenseemann/quic-network-simulator-endpoint
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/docker/qns/martenseemann/quic-network-simulator-endpoint-f65a034f4954a3723f96c5acd782ca7a6676ca87e1b536eceb9a6084ed501591 branch from d6c7222 to c9af5c6 Compare September 9, 2024 09:04
Copy link

github-actions bot commented Sep 9, 2024

Benchmark results

Performance differences relative to 45a2bb1.

coalesce_acked_from_zero 1+1 entries: Change within noise threshold.
       time:   [99.970 ns 100.31 ns 100.66 ns]
       change: [+0.0657% +0.5256% +1.0495%] (p = 0.03 < 0.05)

Found 16 outliers among 100 measurements (16.00%)
12 (12.00%) high mild
4 (4.00%) high severe

coalesce_acked_from_zero 3+1 entries: Change within noise threshold.
       time:   [117.96 ns 118.28 ns 118.63 ns]
       change: [+0.1265% +0.4841% +0.7940%] (p = 0.01 < 0.05)

Found 13 outliers among 100 measurements (13.00%)
2 (2.00%) low mild
11 (11.00%) high severe

coalesce_acked_from_zero 10+1 entries: No change in performance detected.
       time:   [117.65 ns 118.11 ns 118.65 ns]
       change: [-0.9685% +0.1652% +1.1302%] (p = 0.79 > 0.05)

Found 15 outliers among 100 measurements (15.00%)
4 (4.00%) low severe
2 (2.00%) low mild
2 (2.00%) high mild
7 (7.00%) high severe

coalesce_acked_from_zero 1000+1 entries: Change within noise threshold.
       time:   [98.848 ns 99.014 ns 99.202 ns]
       change: [+0.2386% +1.1886% +2.2181%] (p = 0.01 < 0.05)

Found 9 outliers among 100 measurements (9.00%)
4 (4.00%) high mild
5 (5.00%) high severe

RxStreamOrderer::inbound_frame(): Change within noise threshold.
       time:   [112.44 ms 112.58 ms 112.79 ms]
       change: [+0.5612% +0.7961% +1.0394%] (p = 0.00 < 0.05)

Found 3 outliers among 100 measurements (3.00%)
2 (2.00%) high mild
1 (1.00%) high severe

transfer/pacing-false/varying-seeds: No change in performance detected.
       time:   [26.943 ms 27.857 ms 28.803 ms]
       change: [-1.6502% +3.4814% +8.3304%] (p = 0.16 > 0.05)

Found 1 outliers among 100 measurements (1.00%)
1 (1.00%) high mild

transfer/pacing-true/varying-seeds: No change in performance detected.
       time:   [36.069 ms 37.738 ms 39.435 ms]
       change: [-2.9310% +3.0024% +9.5048%] (p = 0.34 > 0.05)
transfer/pacing-false/same-seed: No change in performance detected.
       time:   [31.251 ms 32.029 ms 32.782 ms]
       change: [-3.0195% +0.3370% +3.7175%] (p = 0.85 > 0.05)

Found 1 outliers among 100 measurements (1.00%)
1 (1.00%) low mild

transfer/pacing-true/same-seed: No change in performance detected.
       time:   [41.094 ms 44.237 ms 47.352 ms]
       change: [-9.4710% -0.1556% +10.512%] (p = 0.97 > 0.05)
1-conn/1-100mb-resp (aka. Download)/client: No change in performance detected.
       time:   [114.50 ms 114.93 ms 115.33 ms]
       thrpt:  [867.06 MiB/s 870.09 MiB/s 873.35 MiB/s]
change:
       time:   [-0.4022% +0.7201% +1.5596%] (p = 0.16 > 0.05)
       thrpt:  [-1.5356% -0.7150% +0.4038%]

Found 6 outliers among 100 measurements (6.00%)
6 (6.00%) low mild

1-conn/10_000-parallel-1b-resp (aka. RPS)/client: No change in performance detected.
       time:   [314.32 ms 317.72 ms 321.09 ms]
       thrpt:  [31.144 Kelem/s 31.475 Kelem/s 31.815 Kelem/s]
change:
       time:   [-1.2902% +0.0949% +1.6197%] (p = 0.90 > 0.05)
       thrpt:  [-1.5939% -0.0948% +1.3071%]
1-conn/1-1b-resp (aka. HPS)/client: No change in performance detected.
       time:   [32.438 ms 32.630 ms 32.838 ms]
       thrpt:  [30.452  elem/s 30.647  elem/s 30.828  elem/s]
change:
       time:   [-1.3655% -0.5574% +0.2322%] (p = 0.17 > 0.05)
       thrpt:  [-0.2317% +0.5605% +1.3844%]

Found 8 outliers among 100 measurements (8.00%)
5 (5.00%) high mild
3 (3.00%) high severe

Client/server transfer results

Transfer of 33554432 bytes over loopback.

Client Server CC Pacing Mean [ms] Min [ms] Max [ms] Relative
msquic msquic 122.2 ± 35.7 85.6 192.3 1.00
neqo msquic reno on 212.7 ± 7.1 203.9 226.3 1.00
neqo msquic reno 222.7 ± 13.5 205.2 245.9 1.00
neqo msquic cubic on 288.5 ± 149.1 218.4 703.5 1.00
neqo msquic cubic 223.1 ± 14.4 206.9 254.2 1.00
msquic neqo reno on 91.3 ± 18.6 76.4 158.7 1.00
msquic neqo reno 107.1 ± 61.3 75.1 366.2 1.00
msquic neqo cubic on 87.1 ± 13.5 75.5 122.0 1.00
msquic neqo cubic 90.2 ± 17.9 76.0 154.8 1.00
neqo neqo reno on 193.8 ± 92.6 127.7 415.8 1.00
neqo neqo reno 194.6 ± 103.9 126.0 447.6 1.00
neqo neqo cubic on 157.8 ± 32.9 127.8 249.6 1.00
neqo neqo cubic 239.2 ± 101.1 126.8 398.8 1.00

⬇️ Download logs

@larseggert larseggert merged commit fa2b9d3 into main Sep 9, 2024
53 of 55 checks passed
@larseggert larseggert deleted the dependabot/docker/qns/martenseemann/quic-network-simulator-endpoint-f65a034f4954a3723f96c5acd782ca7a6676ca87e1b536eceb9a6084ed501591 branch September 9, 2024 11:18
Copy link

github-actions bot commented Sep 9, 2024

Firefox builds for this PR

The following builds are available for testing. Crossed-out builds did not succeed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file docker Pull requests that update Docker code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant