build: Optimize dev dependencies #2097
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Noticed this in https://searchfox.org/mozilla-central/source/Cargo.toml It speeds up my local build by ~25%: ``` Benchmark 1: cargo build Time (mean ± σ): 22.947 s ± 0.251 s [User: 165.047 s, System: 9.151 s] Range (min … max): 22.350 s … 23.231 s 10 runs Benchmark 1: cargo build Time (mean ± σ): 16.868 s ± 0.091 s [User: 62.789 s, System: 7.239 s] Range (min … max): 16.721 s … 16.982 s 10 runs ```
larseggert
requested review from
KershawChang,
martinthomson and
mxinden
as code owners
Firefox builds for this PRThe following builds are available for testing. Crossed-out builds did not succeed.
|
|
Hm. This change is not why some builds are faster than others... |
Failed Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
All resultsSucceeded Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
Unsupported Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2097 +/- ##
==========================================
+ Coverage 95.30% 95.33% +0.03%
==========================================
Files 112 112
Lines 36300 36300
==========================================
+ Hits 34594 34607 +13
+ Misses 1706 1693 -13 ☔ View full report in Codecov by Sentry. |
Benchmark resultsPerformance differences relative to fa2b9d3. coalesce_acked_from_zero 1+1 entries: No change in performance detected. time: [99.628 ns 99.966 ns 100.31 ns]
change: [-0.6860% -0.3032% +0.0805%] (p = 0.11 > 0.05)
coalesce_acked_from_zero 3+1 entries: No change in performance detected. time: [117.92 ns 118.24 ns 118.59 ns]
change: [-0.6832% -0.0916% +0.4388%] (p = 0.76 > 0.05)
coalesce_acked_from_zero 10+1 entries: No change in performance detected. time: [117.47 ns 117.80 ns 118.23 ns]
change: [-0.7080% -0.1911% +0.2886%] (p = 0.48 > 0.05)
coalesce_acked_from_zero 1000+1 entries: No change in performance detected. time: [98.908 ns 99.116 ns 99.374 ns]
change: [-0.6007% +0.5227% +1.8912%] (p = 0.40 > 0.05)
RxStreamOrderer::inbound_frame(): Change within noise threshold. time: [111.22 ms 111.36 ms 111.57 ms]
change: [-1.1920% -0.9488% -0.7191%] (p = 0.00 < 0.05)
transfer/pacing-false/varying-seeds: No change in performance detected. time: [25.888 ms 26.925 ms 27.971 ms]
change: [-9.2322% -3.9941% +1.3876%] (p = 0.15 > 0.05)
transfer/pacing-true/varying-seeds: 💚 Performance has improved. time: [33.026 ms 34.556 ms 36.134 ms]
change: [-14.818% -9.2012% -3.7284%] (p = 0.00 < 0.05)
transfer/pacing-false/same-seed: No change in performance detected. time: [31.496 ms 32.266 ms 33.003 ms]
change: [-2.6820% +0.9465% +4.5358%] (p = 0.61 > 0.05)
transfer/pacing-true/same-seed: No change in performance detected. time: [41.201 ms 44.518 ms 47.868 ms]
change: [-9.5398% -0.8862% +8.0681%] (p = 0.85 > 0.05)
1-conn/1-100mb-resp (aka. Download)/client: No change in performance detected. time: [113.29 ms 113.70 ms 114.08 ms]
thrpt: [876.61 MiB/s 879.54 MiB/s 882.70 MiB/s]
change:
time: [-0.8879% -0.3042% +0.2405%] (p = 0.30 > 0.05)
thrpt: [-0.2399% +0.3052% +0.8958%]
1-conn/10_000-parallel-1b-resp (aka. RPS)/client: No change in performance detected. time: [313.99 ms 317.38 ms 320.74 ms]
thrpt: [31.178 Kelem/s 31.508 Kelem/s 31.848 Kelem/s]
change:
time: [-1.1922% +0.2758% +1.7511%] (p = 0.72 > 0.05)
thrpt: [-1.7210% -0.2750% +1.2066%]
1-conn/1-1b-resp (aka. HPS)/client: Change within noise threshold. time: [32.360 ms 32.490 ms 32.634 ms]
thrpt: [30.643 elem/s 30.778 elem/s 30.902 elem/s]
change:
time: [-1.7500% -0.9471% -0.2035%] (p = 0.02 < 0.05)
thrpt: [+0.2039% +0.9562% +1.7812%]
Client/server transfer resultsTransfer of 33554432 bytes over loopback.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed this in https://searchfox.org/mozilla-central/source/Cargo.toml
It speeds up my local build by ~20%: