ci: Use stable Rust to build Firefox #2098
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larseggert
requested review from
KershawChang,
martinthomson and
mxinden
as code owners
larseggert
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2098 +/- ##
=======================================
Coverage 95.33% 95.33%
=======================================
Files 112 112
Lines 36300 36300
=======================================
+ Hits 34607 34608 +1
+ Misses 1693 1692 -1 ☔ View full report in Codecov by Sentry. |
Failed Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
All resultsSucceeded Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
Unsupported Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
|
KershawChang
approved these changes
Sep 11, 2024
Benchmark resultsPerformance differences relative to 70b3914. coalesce_acked_from_zero 1+1 entries: No change in performance detected. time: [99.330 ns 99.661 ns 99.999 ns]
change: [-0.1546% +0.3121% +0.8493%] (p = 0.22 > 0.05)
coalesce_acked_from_zero 3+1 entries: Change within noise threshold. time: [117.56 ns 117.86 ns 118.19 ns]
change: [+0.3045% +0.7602% +1.3280%] (p = 0.00 < 0.05)
coalesce_acked_from_zero 10+1 entries: No change in performance detected. time: [117.33 ns 117.82 ns 118.44 ns]
change: [+0.1793% +3.7248% +10.214%] (p = 0.20 > 0.05)
coalesce_acked_from_zero 1000+1 entries: Change within noise threshold. time: [98.471 ns 98.644 ns 98.837 ns]
change: [+0.0872% +1.1758% +2.1757%] (p = 0.02 < 0.05)
RxStreamOrderer::inbound_frame(): Change within noise threshold. time: [111.20 ms 111.34 ms 111.57 ms]
change: [-0.6768% -0.4292% -0.1779%] (p = 0.00 < 0.05)
transfer/pacing-false/varying-seeds: No change in performance detected. time: [26.410 ms 27.455 ms 28.522 ms]
change: [-5.6865% -0.6404% +5.1848%] (p = 0.82 > 0.05)
transfer/pacing-true/varying-seeds: No change in performance detected. time: [34.892 ms 36.479 ms 38.115 ms]
change: [-8.4642% -2.4936% +3.7990%] (p = 0.44 > 0.05)
transfer/pacing-false/same-seed: No change in performance detected. time: [31.838 ms 32.567 ms 33.274 ms]
change: [-4.5743% -1.6455% +1.5145%] (p = 0.30 > 0.05)
transfer/pacing-true/same-seed: No change in performance detected. time: [42.937 ms 45.746 ms 48.543 ms]
change: [-6.2167% +2.1458% +11.383%] (p = 0.64 > 0.05)
1-conn/1-100mb-resp (aka. Download)/client: 💚 Performance has improved. time: [112.07 ms 112.54 ms 112.98 ms]
thrpt: [885.11 MiB/s 888.56 MiB/s 892.34 MiB/s]
change:
time: [-4.3350% -3.3070% -2.4856%] (p = 0.00 < 0.05)
thrpt: [+2.5490% +3.4201% +4.5314%]
1-conn/10_000-parallel-1b-resp (aka. RPS)/client: No change in performance detected. time: [314.00 ms 317.79 ms 321.55 ms]
thrpt: [31.099 Kelem/s 31.467 Kelem/s 31.847 Kelem/s]
change:
time: [-1.7426% -0.1457% +1.4116%] (p = 0.86 > 0.05)
thrpt: [-1.3920% +0.1459% +1.7735%]
1-conn/1-1b-resp (aka. HPS)/client: No change in performance detected. time: [33.837 ms 33.982 ms 34.132 ms]
thrpt: [29.298 elem/s 29.427 elem/s 29.553 elem/s]
change:
time: [-0.3946% +0.2424% +0.9200%] (p = 0.48 > 0.05)
thrpt: [-0.9116% -0.2418% +0.3961%]
Client/server transfer resultsTransfer of 33554432 bytes over loopback.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://bugzilla.mozilla.org/show_bug.cgi?id=1917407