fix: Remove unnecessary space function
#2122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Funtion is only used internally. Broken out of mozilla#1998
larseggert
requested review from
KershawChang,
martinthomson and
mxinden
as code owners
Failed Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
All resultsSucceeded Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
Unsupported Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2122 +/- ##
==========================================
+ Coverage 95.32% 95.35% +0.02%
==========================================
Files 112 112
Lines 36319 36316 -3
==========================================
+ Hits 34621 34628 +7
+ Misses 1698 1688 -10 ☔ View full report in Codecov by Sentry. |
mxinden
approved these changes
Sep 17, 2024
Benchmark resultsPerformance differences relative to 75372c2. coalesce_acked_from_zero 1+1 entries: No change in performance detected. time: [98.777 ns 99.050 ns 99.328 ns]
change: [-0.7752% -0.3055% +0.1333%] (p = 0.20 > 0.05)
coalesce_acked_from_zero 3+1 entries: No change in performance detected. time: [116.72 ns 117.67 ns 119.27 ns]
change: [-0.4508% +0.2318% +1.0232%] (p = 0.59 > 0.05)
coalesce_acked_from_zero 10+1 entries: No change in performance detected. time: [116.40 ns 116.91 ns 117.51 ns]
change: [-0.4929% -0.0045% +0.5083%] (p = 0.98 > 0.05)
coalesce_acked_from_zero 1000+1 entries: No change in performance detected. time: [97.228 ns 97.360 ns 97.523 ns]
change: [-1.0920% -0.2625% +0.5787%] (p = 0.55 > 0.05)
RxStreamOrderer::inbound_frame(): No change in performance detected. time: [111.16 ms 111.23 ms 111.30 ms]
change: [-0.0287% +0.0518% +0.1382%] (p = 0.21 > 0.05)
transfer/pacing-false/varying-seeds: No change in performance detected. time: [27.071 ms 28.181 ms 29.306 ms]
change: [-5.5967% +0.1198% +5.5304%] (p = 0.97 > 0.05)
transfer/pacing-true/varying-seeds: No change in performance detected. time: [34.107 ms 35.835 ms 37.555 ms]
change: [-9.7678% -3.9699% +2.6443%] (p = 0.22 > 0.05)
transfer/pacing-false/same-seed: No change in performance detected. time: [32.094 ms 32.855 ms 33.597 ms]
change: [-3.0760% +0.3472% +3.9291%] (p = 0.84 > 0.05)
transfer/pacing-true/same-seed: No change in performance detected. time: [39.225 ms 41.559 ms 43.891 ms]
change: [-10.889% -2.6486% +6.7459%] (p = 0.56 > 0.05)
1-conn/1-100mb-resp (aka. Download)/client: No change in performance detected. time: [112.55 ms 113.03 ms 113.51 ms]
thrpt: [881.02 MiB/s 884.70 MiB/s 888.53 MiB/s]
change:
time: [-6.9519% -2.2019% +0.5804%] (p = 0.52 > 0.05)
thrpt: [-0.5771% +2.2514% +7.4713%]
1-conn/10_000-parallel-1b-resp (aka. RPS)/client: No change in performance detected. time: [311.51 ms 314.53 ms 317.52 ms]
thrpt: [31.494 Kelem/s 31.793 Kelem/s 32.102 Kelem/s]
change:
time: [-2.1127% -0.7543% +0.7079%] (p = 0.32 > 0.05)
thrpt: [-0.7029% +0.7600% +2.1583%]
1-conn/1-1b-resp (aka. HPS)/client: No change in performance detected. time: [33.912 ms 34.139 ms 34.387 ms]
thrpt: [29.081 elem/s 29.292 elem/s 29.488 elem/s]
change:
time: [-0.4306% +0.4118% +1.3267%] (p = 0.36 > 0.05)
thrpt: [-1.3093% -0.4101% +0.4324%]
Client/server transfer resultsTransfer of 33554432 bytes over loopback.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Funtion is only used internally.
Broken out of #1998