Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Move NSS location out of github.workspace #2126

Closed
wants to merge 2 commits into from

Conversation

larseggert
Copy link
Collaborator

In the hopes that CodeCov hence won't try and upload various NSS files as part of the coverage report.

In the hopes that CodeCov hence won't try and upload various NSS files
as part of the coverage report.
@larseggert
Copy link
Collaborator Author

Seems to be a CodeCov issue, reported as codecov/feedback#515.

@larseggert larseggert closed this Sep 18, 2024
Copy link

Failed Interop Tests

QUIC Interop Runner, client vs. server

neqo-latest as client

neqo-latest as server

All results

Succeeded Interop Tests

QUIC Interop Runner, client vs. server

neqo-latest as client

neqo-latest as server

Unsupported Interop Tests

QUIC Interop Runner, client vs. server

neqo-latest as client

neqo-latest as server

Copy link

Benchmark results

Performance differences relative to eb3e835.

coalesce_acked_from_zero 1+1 entries: Change within noise threshold.
       time:   [101.17 ns 101.50 ns 101.82 ns]
       change: [+0.8509% +1.3717% +1.8888%] (p = 0.00 < 0.05)

Found 11 outliers among 100 measurements (11.00%)
6 (6.00%) high mild
5 (5.00%) high severe

coalesce_acked_from_zero 3+1 entries: Change within noise threshold.
       time:   [118.96 ns 119.32 ns 119.71 ns]
       change: [+0.0595% +0.6865% +1.1964%] (p = 0.01 < 0.05)

Found 15 outliers among 100 measurements (15.00%)
1 (1.00%) low mild
4 (4.00%) high mild
10 (10.00%) high severe

coalesce_acked_from_zero 10+1 entries: Change within noise threshold.
       time:   [118.56 ns 118.89 ns 119.33 ns]
       change: [+0.8080% +1.5540% +2.5323%] (p = 0.00 < 0.05)

Found 12 outliers among 100 measurements (12.00%)
2 (2.00%) low severe
4 (4.00%) low mild
6 (6.00%) high severe

coalesce_acked_from_zero 1000+1 entries: No change in performance detected.
       time:   [98.867 ns 99.018 ns 99.189 ns]
       change: [-0.3321% +0.4487% +1.2218%] (p = 0.26 > 0.05)

Found 9 outliers among 100 measurements (9.00%)
4 (4.00%) high mild
5 (5.00%) high severe

RxStreamOrderer::inbound_frame(): No change in performance detected.
       time:   [110.65 ms 110.78 ms 111.00 ms]
       change: [-0.1192% +0.0179% +0.2312%] (p = 0.88 > 0.05)

Found 17 outliers among 100 measurements (17.00%)
7 (7.00%) low mild
9 (9.00%) high mild
1 (1.00%) high severe

transfer/pacing-false/varying-seeds: No change in performance detected.
       time:   [26.514 ms 27.520 ms 28.538 ms]
       change: [-4.4533% +0.7761% +6.4577%] (p = 0.78 > 0.05)

Found 2 outliers among 100 measurements (2.00%)
2 (2.00%) high mild

transfer/pacing-true/varying-seeds: No change in performance detected.
       time:   [34.397 ms 35.923 ms 37.458 ms]
       change: [-4.0215% +1.8288% +8.6874%] (p = 0.57 > 0.05)

Found 2 outliers among 100 measurements (2.00%)
2 (2.00%) low mild

transfer/pacing-false/same-seed: No change in performance detected.
       time:   [24.804 ms 25.485 ms 26.180 ms]
       change: [-4.8694% -1.1828% +2.7557%] (p = 0.55 > 0.05)

Found 2 outliers among 100 measurements (2.00%)
1 (1.00%) low mild
1 (1.00%) high mild

transfer/pacing-true/same-seed: No change in performance detected.
       time:   [39.582 ms 41.561 ms 43.580 ms]
       change: [-4.5863% +2.4811% +9.5859%] (p = 0.50 > 0.05)

Found 1 outliers among 100 measurements (1.00%)
1 (1.00%) high mild

1-conn/1-100mb-resp (aka. Download)/client: Change within noise threshold.
       time:   [114.65 ms 115.10 ms 115.53 ms]
       thrpt:  [865.58 MiB/s 868.79 MiB/s 872.20 MiB/s]
change:
       time:   [+0.1645% +1.3259% +2.2367%] (p = 0.01 < 0.05)
       thrpt:  [-2.1878% -1.3085% -0.1642%]

Found 4 outliers among 100 measurements (4.00%)
4 (4.00%) low mild

1-conn/10_000-parallel-1b-resp (aka. RPS)/client: No change in performance detected.
       time:   [314.54 ms 318.31 ms 322.06 ms]
       thrpt:  [31.050 Kelem/s 31.416 Kelem/s 31.793 Kelem/s]
change:
       time:   [-1.4640% +0.2164% +1.9411%] (p = 0.80 > 0.05)
       thrpt:  [-1.9041% -0.2159% +1.4857%]
1-conn/1-1b-resp (aka. HPS)/client: No change in performance detected.
       time:   [34.055 ms 34.215 ms 34.387 ms]
       thrpt:  [29.081  elem/s 29.227  elem/s 29.365  elem/s]
change:
       time:   [-0.0471% +0.7149% +1.4383%] (p = 0.06 > 0.05)
       thrpt:  [-1.4179% -0.7098% +0.0472%]

Found 3 outliers among 100 measurements (3.00%)
3 (3.00%) high mild

Client/server transfer results

Transfer of 33554432 bytes over loopback.

Client Server CC Pacing Mean [ms] Min [ms] Max [ms] Relative
msquic msquic 190.1 ± 109.6 97.5 413.2 1.00
neqo msquic reno on 216.8 ± 12.4 204.5 238.8 1.00
neqo msquic reno 255.9 ± 71.2 212.4 450.8 1.00
neqo msquic cubic on 217.9 ± 13.1 204.3 238.7 1.00
neqo msquic cubic 251.1 ± 67.7 212.2 449.2 1.00
msquic neqo reno on 125.8 ± 76.5 82.9 325.2 1.00
msquic neqo reno 110.4 ± 58.0 81.1 325.2 1.00
msquic neqo cubic on 145.8 ± 65.7 90.9 281.3 1.00
msquic neqo cubic 206.3 ± 87.2 90.7 320.0 1.00
neqo neqo reno on 236.2 ± 125.6 131.3 596.3 1.00
neqo neqo reno 222.9 ± 114.4 130.5 490.2 1.00
neqo neqo cubic on 264.3 ± 137.2 128.1 656.7 1.00
neqo neqo cubic 194.1 ± 79.8 129.3 386.9 1.00

⬇️ Download logs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant