ci(nss): fix typo USE_SYSTEM USE_SYSTEM_NSS #2145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mxinden
requested review from
KershawChang,
martinthomson and
larseggert
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2145 +/- ##
==========================================
- Coverage 95.35% 95.35% -0.01%
==========================================
Files 112 112
Lines 36345 36345
==========================================
- Hits 34657 34656 -1
- Misses 1688 1689 +1 ☔ View full report in Codecov by Sentry. |
martinthomson
approved these changes
Oct 2, 2024
Benchmark resultsPerformance differences relative to a4c4ccd. coalesce_acked_from_zero 1+1 entries: No change in performance detected. time: [98.652 ns 99.306 ns 100.17 ns]
change: [-0.8204% -0.0623% +0.8609%] (p = 0.91 > 0.05)
coalesce_acked_from_zero 3+1 entries: No change in performance detected. time: [116.59 ns 116.97 ns 117.36 ns]
change: [-0.5644% -0.1733% +0.1871%] (p = 0.38 > 0.05)
coalesce_acked_from_zero 10+1 entries: Change within noise threshold. time: [116.01 ns 116.35 ns 116.78 ns]
change: [-2.0685% -0.9588% -0.0989%] (p = 0.05 < 0.05)
coalesce_acked_from_zero 1000+1 entries: Change within noise threshold. time: [97.301 ns 97.474 ns 97.667 ns]
change: [-2.2049% -1.0876% +0.0649%] (p = 0.04 < 0.05)
RxStreamOrderer::inbound_frame(): Change within noise threshold. time: [110.88 ms 110.94 ms 111.00 ms]
change: [-0.6022% -0.3958% -0.2550%] (p = 0.00 < 0.05)
transfer/pacing-false/varying-seeds: No change in performance detected. time: [26.929 ms 27.971 ms 29.000 ms]
change: [-4.3381% +1.3921% +7.3039%] (p = 0.64 > 0.05)
transfer/pacing-true/varying-seeds: No change in performance detected. time: [35.441 ms 37.017 ms 38.598 ms]
change: [-8.4597% -2.6072% +3.2677%] (p = 0.39 > 0.05)
transfer/pacing-false/same-seed: No change in performance detected. time: [25.757 ms 26.590 ms 27.433 ms]
change: [-7.8196% -3.5598% +0.4616%] (p = 0.10 > 0.05)
transfer/pacing-true/same-seed: No change in performance detected. time: [39.599 ms 41.651 ms 43.797 ms]
change: [-8.1043% -1.1319% +6.2190%] (p = 0.76 > 0.05)
1-conn/1-100mb-resp (aka. Download)/client: No change in performance detected. time: [113.13 ms 113.60 ms 114.04 ms]
thrpt: [876.87 MiB/s 880.24 MiB/s 883.90 MiB/s]
change:
time: [-0.9537% -0.3193% +0.3480%] (p = 0.35 > 0.05)
thrpt: [-0.3468% +0.3204% +0.9629%]
1-conn/10_000-parallel-1b-resp (aka. RPS)/client: No change in performance detected. time: [311.06 ms 314.86 ms 318.64 ms]
thrpt: [31.383 Kelem/s 31.761 Kelem/s 32.148 Kelem/s]
change:
time: [-2.7492% -1.3046% +0.2160%] (p = 0.11 > 0.05)
thrpt: [-0.2156% +1.3219% +2.8269%]
1-conn/1-1b-resp (aka. HPS)/client: No change in performance detected. time: [34.151 ms 34.300 ms 34.465 ms]
thrpt: [29.015 elem/s 29.154 elem/s 29.281 elem/s]
change:
time: [-0.0999% +0.6011% +1.3414%] (p = 0.11 > 0.05)
thrpt: [-1.3236% -0.5975% +0.1000%]
Client/server transfer resultsTransfer of 33554432 bytes over loopback.
|
Failed Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
All resultsSucceeded Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
Unsupported Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.