chore: keep neqo_transport::Error internal errors sorted #2149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As per the comment:
```rust
// All internal errors from here. Please keep these sorted.
```
mxinden
requested review from
KershawChang,
martinthomson and
larseggert
as code owners
Failed Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
All resultsSucceeded Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
Unsupported Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
|
Benchmark resultsPerformance differences relative to 1708886. coalesce_acked_from_zero 1+1 entries: No change in performance detected. time: [98.947 ns 99.267 ns 99.595 ns]
change: [-1.2745% -0.3236% +0.6316%] (p = 0.54 > 0.05)
coalesce_acked_from_zero 3+1 entries: Change within noise threshold. time: [116.68 ns 117.01 ns 117.38 ns]
change: [-1.6491% -1.1483% -0.7239%] (p = 0.00 < 0.05)
coalesce_acked_from_zero 10+1 entries: Change within noise threshold. time: [116.51 ns 117.03 ns 117.64 ns]
change: [-1.2337% -0.6911% -0.1800%] (p = 0.01 < 0.05)
coalesce_acked_from_zero 1000+1 entries: No change in performance detected. time: [97.684 ns 97.857 ns 98.057 ns]
change: [-1.5468% -0.4375% +0.9755%] (p = 0.52 > 0.05)
RxStreamOrderer::inbound_frame(): Change within noise threshold. time: [111.98 ms 112.12 ms 112.34 ms]
change: [+0.3445% +0.4814% +0.6783%] (p = 0.00 < 0.05)
transfer/pacing-false/varying-seeds: Change within noise threshold. time: [25.955 ms 26.888 ms 27.822 ms]
change: [-9.9241% -5.8540% -1.3304%] (p = 0.01 < 0.05)
transfer/pacing-true/varying-seeds: No change in performance detected. time: [35.327 ms 37.078 ms 38.858 ms]
change: [-4.8478% +1.7221% +8.3697%] (p = 0.61 > 0.05)
transfer/pacing-false/same-seed: Change within noise threshold. time: [26.499 ms 27.350 ms 28.212 ms]
change: [+1.0514% +6.0347% +10.691%] (p = 0.01 < 0.05)
transfer/pacing-true/same-seed: No change in performance detected. time: [39.097 ms 41.064 ms 43.072 ms]
change: [-11.041% -5.2123% +1.3621%] (p = 0.12 > 0.05)
1-conn/1-100mb-resp (aka. Download)/client: Change within noise threshold. time: [113.55 ms 113.95 ms 114.34 ms]
thrpt: [874.59 MiB/s 877.60 MiB/s 880.70 MiB/s]
change:
time: [-0.0428% +1.1631% +2.1393%] (p = 0.03 < 0.05)
thrpt: [-2.0945% -1.1498% +0.0429%]
1-conn/10_000-parallel-1b-resp (aka. RPS)/client: No change in performance detected. time: [313.27 ms 317.05 ms 320.78 ms]
thrpt: [31.174 Kelem/s 31.541 Kelem/s 31.922 Kelem/s]
change:
time: [-0.6007% +1.1002% +2.7170%] (p = 0.19 > 0.05)
thrpt: [-2.6451% -1.0882% +0.6043%]
1-conn/1-1b-resp (aka. HPS)/client: No change in performance detected. time: [33.783 ms 33.980 ms 34.191 ms]
thrpt: [29.247 elem/s 29.429 elem/s 29.600 elem/s]
change:
time: [-1.1128% -0.1094% +0.9270%] (p = 0.83 > 0.05)
thrpt: [-0.9185% +0.1095% +1.1254%]
Client/server transfer resultsTransfer of 33554432 bytes over loopback.
|
larseggert
approved these changes
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per the comment:
neqo/neqo-transport/src/lib.rs
Line 102 in 1708886