Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Build only netwerk component on CI #2164

Closed
wants to merge 14 commits into from
Closed

ci: Build only netwerk component on CI #2164

wants to merge 14 commits into from

Conversation

larseggert
Copy link
Collaborator

@larseggert larseggert commented Oct 9, 2024 •
edited
Loading

Save some trees by only building the netwerk bits of Firefox in CI. To build the entire browser, do a manual workload_dispatch.

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 9, 2024 •
edited
Loading

Failed Interop Tests

QUIC Interop Runner, client vs. server

neqo-latest as client

neqo-latest as server

All results

Succeeded Interop Tests

QUIC Interop Runner, client vs. server

neqo-latest as client

neqo-latest as server

Unsupported Interop Tests

QUIC Interop Runner, client vs. server

neqo-latest as client

neqo-latest as server

@codecov Codecov
Copy link

codecov bot commented Oct 9, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.38%. Comparing base (f39e12e) to head (c457767).
Report is 12 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2164      +/-   ##
==========================================
- Coverage   95.39%   95.38%   -0.01%     
==========================================
  Files         112      112              
  Lines       36373    36373              
==========================================
- Hits        34697    34696       -1     
- Misses       1676     1677       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@larseggert larseggert changed the title ci: Try to build neqo_glue on CI ci: Build only neqo_glue on CI Oct 9, 2024
@larseggert larseggert changed the title ci: Build only neqo_glue on CI ci: Build only netwerk component on CI Oct 9, 2024
@larseggert
Copy link
Collaborator Author

larseggert commented Oct 9, 2024 •
edited
Loading

@mxinden the ./mach build netwerk bit you suggested is failing. Any ideas?

 0:43.82 gmake[3]: *** No rule to make target 'MozURL_ffi.h', needed by '../../../dist/include/mozilla/net/MozURL_ffi.h'.  Stop.
 0:43.82 gmake[2]: *** [/home/runner/work/neqo/neqo/mozilla-unified/config/recurse.mk:140: export] Error 2
 0:43.82 gmake[1]: *** [/home/runner/work/neqo/neqo/mozilla-unified/config/recurse.mk:140: export] Error 2
 0:43.82 gmake: *** [/home/runner/work/neqo/neqo/mozilla-unified/config/rules.mk:359: default] Error 2
 0:43.92 W 0 compiler warnings present.
 Config object not found by mach.
Configure complete!
Be sure to run |mach build| to pick up any changes
  Parallelism determined by memory: using 4 jobs for 4 cores based on 15.6 GiB RAM and estimated job size of 1.0 GiB
Hey! Builds initiated with `mach build $A_SPECIFIC_TARGET` may not always work, even if the code being built is correct. Consider doing a bare `mach build` instead.

@mxinden
Copy link
Collaborator

mxinden commented Oct 10, 2024

Sorry for leading you astray here. As discussed on Slack, I guess there is no way to build netwerk only.

@larseggert
Copy link
Collaborator Author

This seems to be impossible.

@larseggert larseggert closed this Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KershawChang KershawChang Awaiting requested review from KershawChang KershawChang will be requested when the pull request is marked ready for review KershawChang is a code owner

@martinthomson martinthomson Awaiting requested review from martinthomson martinthomson will be requested when the pull request is marked ready for review martinthomson is a code owner

@mxinden mxinden Awaiting requested review from mxinden mxinden will be requested when the pull request is marked ready for review mxinden is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@larseggert @mxinden