feat: Plumbing to begin supporting QNS migration tests #2167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And a small bit of cleanup to avoid repetition.
larseggert
requested review from
KershawChang,
martinthomson and
mxinden
as code owners
mxinden
approved these changes
Oct 11, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2167 +/- ##
==========================================
- Coverage 95.39% 95.38% -0.01%
==========================================
Files 112 112
Lines 36373 36373
==========================================
- Hits 34697 34696 -1
- Misses 1676 1677 +1 ☔ View full report in Codecov by Sentry. |
Failed Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
All resultsSucceeded Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
Unsupported Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
|
Benchmark resultsPerformance differences relative to 9ef0355. coalesce_acked_from_zero 1+1 entries: No change in performance detected. time: [98.526 ns 98.790 ns 99.059 ns]
change: [-0.5453% -0.1830% +0.1785%] (p = 0.34 > 0.05)
coalesce_acked_from_zero 3+1 entries: No change in performance detected. time: [116.58 ns 116.90 ns 117.25 ns]
change: [-0.4508% -0.0600% +0.3070%] (p = 0.76 > 0.05)
coalesce_acked_from_zero 10+1 entries: No change in performance detected. time: [116.14 ns 116.44 ns 116.85 ns]
change: [-3.6393% -1.1859% +0.3081%] (p = 0.36 > 0.05)
coalesce_acked_from_zero 1000+1 entries: No change in performance detected. time: [97.317 ns 97.465 ns 97.625 ns]
change: [-7.6777% -2.8885% +0.1310%] (p = 0.23 > 0.05)
RxStreamOrderer::inbound_frame(): No change in performance detected. time: [110.92 ms 110.98 ms 111.05 ms]
change: [-0.0598% +0.0134% +0.0920%] (p = 0.72 > 0.05)
transfer/pacing-false/varying-seeds: No change in performance detected. time: [26.305 ms 27.411 ms 28.566 ms]
change: [-4.1618% +1.3778% +7.1263%] (p = 0.63 > 0.05)
transfer/pacing-true/varying-seeds: No change in performance detected. time: [34.233 ms 35.606 ms 36.968 ms]
change: [-6.8924% -1.4364% +4.6622%] (p = 0.62 > 0.05)
transfer/pacing-false/same-seed: No change in performance detected. time: [25.609 ms 26.497 ms 27.388 ms]
change: [-4.7670% -0.5602% +3.5866%] (p = 0.80 > 0.05)
transfer/pacing-true/same-seed: No change in performance detected. time: [39.695 ms 41.928 ms 44.202 ms]
change: [-11.564% -4.5457% +2.6703%] (p = 0.21 > 0.05)
1-conn/1-100mb-resp (aka. Download)/client: No change in performance detected. time: [114.61 ms 115.07 ms 115.59 ms]
thrpt: [865.09 MiB/s 869.02 MiB/s 872.51 MiB/s]
change:
time: [-0.1442% +0.3649% +0.8957%] (p = 0.18 > 0.05)
thrpt: [-0.8877% -0.3636% +0.1444%]
1-conn/10_000-parallel-1b-resp (aka. RPS)/client: No change in performance detected. time: [308.87 ms 312.89 ms 316.95 ms]
thrpt: [31.551 Kelem/s 31.960 Kelem/s 32.376 Kelem/s]
change:
time: [-2.6210% -0.7589% +1.1196%] (p = 0.43 > 0.05)
thrpt: [-1.1072% +0.7647% +2.6916%]
1-conn/1-1b-resp (aka. HPS)/client: No change in performance detected. time: [33.888 ms 34.063 ms 34.251 ms]
thrpt: [29.196 elem/s 29.358 elem/s 29.509 elem/s]
change:
time: [-1.2100% -0.3409% +0.4448%] (p = 0.44 > 0.05)
thrpt: [-0.4428% +0.3421% +1.2248%]
Client/server transfer resultsTransfer of 33554432 bytes over loopback.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And a small bit of cleanup to avoid repetition.