test: Make sure our PATH_CHALLENGEs are padded OK #2168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larseggert
requested review from
KershawChang,
martinthomson and
mxinden
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2168 +/- ##
=======================================
Coverage 95.39% 95.39%
=======================================
Files 112 112
Lines 36373 36373
=======================================
Hits 34697 34697
Misses 1676 1676 ☔ View full report in Codecov by Sentry. |
Failed Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
All resultsSucceeded Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
Unsupported Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
|
Benchmark resultsPerformance differences relative to 944c817. coalesce_acked_from_zero 1+1 entries: No change in performance detected. time: [99.046 ns 99.323 ns 99.609 ns]
change: [-1.2364% -0.5767% +0.0194%] (p = 0.08 > 0.05)
coalesce_acked_from_zero 3+1 entries: Change within noise threshold. time: [116.83 ns 117.16 ns 117.52 ns]
change: [-1.0145% -0.6455% -0.3072%] (p = 0.00 < 0.05)
coalesce_acked_from_zero 10+1 entries: No change in performance detected. time: [116.39 ns 116.68 ns 117.07 ns]
change: [-0.9367% -0.4078% +0.1930%] (p = 0.17 > 0.05)
coalesce_acked_from_zero 1000+1 entries: Change within noise threshold. time: [97.257 ns 97.394 ns 97.545 ns]
change: [-1.8531% -0.9445% +0.0496%] (p = 0.04 < 0.05)
RxStreamOrderer::inbound_frame(): 💚 Performance has improved. time: [110.83 ms 110.90 ms 110.97 ms]
change: [-2.5983% -2.5278% -2.4563%] (p = 0.00 < 0.05)
transfer/pacing-false/varying-seeds: No change in performance detected. time: [25.612 ms 26.570 ms 27.571 ms]
change: [-9.3672% -4.4105% +0.8099%] (p = 0.10 > 0.05)
transfer/pacing-true/varying-seeds: No change in performance detected. time: [34.260 ms 35.776 ms 37.320 ms]
change: [-7.9491% -2.2514% +3.6214%] (p = 0.48 > 0.05)
transfer/pacing-false/same-seed: No change in performance detected. time: [24.331 ms 25.159 ms 25.996 ms]
change: [-8.4426% -4.3091% +0.2043%] (p = 0.06 > 0.05)
transfer/pacing-true/same-seed: Change within noise threshold. time: [38.905 ms 40.813 ms 42.806 ms]
change: [-14.666% -8.6991% -2.7225%] (p = 0.01 < 0.05)
1-conn/1-100mb-resp (aka. Download)/client: Change within noise threshold. time: [113.76 ms 114.19 ms 114.59 ms]
thrpt: [872.67 MiB/s 875.75 MiB/s 879.04 MiB/s]
change:
time: [+0.3551% +0.9333% +1.5106%] (p = 0.00 < 0.05)
thrpt: [-1.4881% -0.9246% -0.3538%]
1-conn/10_000-parallel-1b-resp (aka. RPS)/client: No change in performance detected. time: [310.91 ms 314.69 ms 318.48 ms]
thrpt: [31.399 Kelem/s 31.777 Kelem/s 32.164 Kelem/s]
change:
time: [-0.8729% +0.6978% +2.4220%] (p = 0.41 > 0.05)
thrpt: [-2.3647% -0.6930% +0.8806%]
1-conn/1-1b-resp (aka. HPS)/client: No change in performance detected. time: [33.866 ms 34.051 ms 34.243 ms]
thrpt: [29.203 elem/s 29.368 elem/s 29.528 elem/s]
change:
time: [-0.6378% +0.1628% +0.9781%] (p = 0.69 > 0.05)
thrpt: [-0.9686% -0.1625% +0.6419%]
Client/server transfer resultsTransfer of 33554432 bytes over loopback.
|
mxinden
approved these changes
Oct 16, 2024
martinthomson
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.