Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switched chokidar dependency to npm version #217

Merged
merged 1 commit into from
Apr 4, 2014
Merged

Switched chokidar dependency to npm version #217

merged 1 commit into from
Apr 4, 2014

Conversation

tyler-johnson
Copy link
Contributor

Helps with #216.

@jlongster
Copy link
Contributor

I forget why we linked directly to the repo in the first place -- wasn't it about something fixed on OS X?

@tyler-johnson
Copy link
Contributor Author

Yes it was an attempt to fix the usePolling: true. I had some custom code that was being tested for chokidar and fsevents. Both have closed the issues and I haven't run into any trouble since. If usePolling is still true, that can be switched back to false (or deleted completely).

jlongster added a commit that referenced this pull request Apr 4, 2014
@jlongster
Merge pull request #217 from tyler-johnson/master
b50ae1f 
Switched chokidar dependency to npm version
@jlongster jlongster merged commit b50ae1f into mozilla:master Apr 4, 2014
@jlongster
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tyler-johnson @jlongster