Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broadened Windows precompile support to include strings #825

Merged
merged 3 commits into from
Aug 31, 2016

Conversation

kim3er
Copy link
Contributor

@kim3er kim3er commented Aug 31, 2016

I initially created #761 to deal with incorrectly formatted paths, when precompiling in Windows. The original pull request only dealt with directories, this change also deals with strings.

}
});

expect(fileName).to.not.contain('\\');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not make a stronger assertion about what the filename should be?

@kim3er
Copy link
Contributor Author

kim3er commented Aug 31, 2016

Updated with clearer assertions on resulting names.

@carljm
Copy link
Contributor

carljm commented Aug 31, 2016

Can you add a changelog entry (in the 2.x section) with a link to this PR, like the existing entries? Thanks!

@kim3er
Copy link
Contributor Author

kim3er commented Aug 31, 2016

Done. :)

@carljm carljm merged commit 28529a3 into mozilla:master Aug 31, 2016
carljm pushed a commit that referenced this pull request Aug 31, 2016
* Broadened Windows precompile support to include strings

* clearer assertions on resulting filenames

* Updated changelog to include OS agnostic file paths in precompile
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants