Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add missing quote #886

Merged
merged 1 commit into from
Oct 12, 2016
Merged

add missing quote #886

merged 1 commit into from
Oct 12, 2016

Conversation

pd4d10
Copy link
Contributor

@pd4d10 pd4d10 commented Oct 8, 2016

Summary

Proposed change:

Add missing quote in Chinese documentation.

Checklist

I've completed the checklist below to ensure I didn't forget anything. This makes reviewing this PR as easy as possible for the maintainers. And it gets this change released as soon as possible.

@vecmezoni vecmezoni merged commit a89abbe into mozilla:gh-pages Oct 12, 2016
@vecmezoni
Copy link
Collaborator

Thanks!

@vecmezoni
Copy link
Collaborator

Pooh! @pd4d10, could you please provide pull request for master branch? You'd fixed this in gh-pages branch that is being just generated from master.

@pd4d10
Copy link
Contributor Author

pd4d10 commented Oct 12, 2016

It seems that redcarpet with_toc_data couldn't correctly handle non-ASCII character, vmg/redcarpet#538

This is a temporary solution to make this doc display correctly.

@vecmezoni
Copy link
Collaborator

That's sad. Your fix will break with next release 😿

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants