Merge pull request #11182 from Snuffleupagus/disableWorker-disable-Di…

…ct-postMessage Forbid sending of `Dict`s and `Stream`s, with `postMessage`, when workers are disabled
mozilla · Sep 29, 2019 · 8c4f4b5 · 8c4f4b5
2 parents 06e4eb4 + 3f8fee3
commit 8c4f4b5
Showing 1 changed file with 8 additions and 2 deletions.
diff --git a/src/display/api.js b/src/display/api.js
@@ -1463,8 +1463,14 @@ class LoopbackPort {
         while (!(desc = Object.getOwnPropertyDescriptor(p, i))) {
           p = Object.getPrototypeOf(p);
         }
-        if (typeof desc.value === 'undefined' ||
-            typeof desc.value === 'function') {
+        if (typeof desc.value === 'undefined') {
+          continue;
+        }
+        if (typeof desc.value === 'function') {
+          if (value.hasOwnProperty && value.hasOwnProperty(i)) {
+            throw new Error(
+              `LoopbackPort.postMessage - cannot clone: ${value[i]}`);
+          }
           continue;
         }
         result[i] = cloneValue(desc.value);