Merge pull request #8138 from Snuffleupagus/bug-1345253

Get rid of `element.removeChild(element.firstChild)` usage (bug 1345253)
mozilla · Mar 8, 2017 · a544a3b · a544a3b
2 parents 754c4bd + 468ed1b
commit a544a3b
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 8 deletions.
diff --git a/web/pdf_attachment_viewer.js b/web/pdf_attachment_viewer.js
@@ -61,10 +61,8 @@ var PDFAttachmentViewer = (function PDFAttachmentViewerClosure() {
     reset: function PDFAttachmentViewer_reset(keepRenderedCapability) {
       this.attachments = null;
 
-      var container = this.container;
-      while (container.firstChild) {
-        container.removeChild(container.firstChild);
-      }
+      // Remove the attachments from the DOM.
+      this.container.textContent = '';
 
       if (!keepRenderedCapability) {
         // NOTE: The *only* situation in which the `_renderedCapability` should

diff --git a/web/pdf_outline_viewer.js b/web/pdf_outline_viewer.js
@@ -63,10 +63,11 @@ var PDFOutlineViewer = (function PDFOutlineViewerClosure() {
       this.outline = null;
       this.lastToggleIsShow = true;
 
-      var container = this.container;
-      while (container.firstChild) {
-        container.removeChild(container.firstChild);
-      }
+      // Remove the outline from the DOM.
+      this.container.textContent = '';
+      // Ensure that the left (right in RTL locales) margin is always reset,
+      // to prevent incorrect outline alignment if a new document is opened.
+      this.container.classList.remove('outlineWithDeepNesting');
     },
 
     /**