Should use peerDependenciesMeta for worker-loader

[tamuratak]

Related to #11474 and #12815.

The following should be added to package.json of pdfjs-dist for worker-loader.

  "peerDependenciesMeta": {
    "worker-loader": {
      "optional": true
    }
  }

npm v7 installs peerDependencies by default. We can see that calling npm install pdfjs-dist in an empty directory will install webpack and others in node_modules.

In npm versions 3 through 6, peerDependencies were not automatically installed, and would raise a warning if an invalid version of the peer dependency was found in the tree. As of npm v7, peerDependencies are installed by default.

• https://docs.npmjs.com/cli/v7/configuring-npm/package-json#peerdependencies
• https://github.blog/2020-10-13-presenting-v7-0-0-of-the-npm-cli/

We can make worker-loader optional with peerDependenciesMeta.

• https://docs.npmjs.com/cli/v7/configuring-npm/package-json#peerdependenciesmeta
• [RRFC] No auto-install for peerDependencies marked as optional npm/rfcs#221

[Snuffleupagus]

The following should be added to package.json of pdfjs-dist for worker-loader.

  "peerDependenciesMeta": {
    "worker-loader": {
      "optional": true
    }
  }

@tamuratak That looks completely reasonable as far as I can tell; do you want to submit a patch?
The new code should be added just after the following block (since the package.json file is generated):

pdf.js/gulpfile.js

Lines 2020 to 2022 in 3ec1bac

	peerDependencies: {
	"worker-loader": "^3.0.7", // Used in `external/dist/webpack.js`.
	},

Also, if we're editing this code anyway I'd suggest bumping the worker-loader package to use version ^3.0.8 as well.

[synedra-mpe]

Can someone please trigger a release of pdfjs-dist v2.11.338 on npmjs.com to make use of these fixes?

[Snuffleupagus]

Can someone please trigger a release of pdfjs-dist v2.11.338 on npmjs.com to make use of these fixes?

See https://www.npmjs.com/package/pdfjs-dist?activeTab=versions

[synedra-mpe]

Thanks a lot for pointing me to the ricght direction. yarn add pdfjs-dist@next worked.